Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] 시간표 3차 구현 #473

Merged
merged 40 commits into from
Nov 14, 2024
Merged

[Feature] 시간표 3차 구현 #473

merged 40 commits into from
Nov 14, 2024

Conversation

Jokwanhee
Copy link
Collaborator

요약

  • 학기 연결 제외한 구현 완료

추가사항

  • 작업이 계속 이어지다보니 PR이 좀 묵직합니다. �
  • 지저분하거나 개선되어야할 부분은 나중에 리팩토링 할 것 같습니다!
  • 따로 리뷰없이 어프로브 해주시면 감사하겠습니다 🙇🏻

@Jokwanhee Jokwanhee self-assigned this Nov 13, 2024
@Jokwanhee Jokwanhee requested a review from a team as a code owner November 13, 2024 17:17
Copy link
Contributor

@nodobi nodobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 이번에 리팩토링 진행하면서 같이 테스트 코드 적극적으로 써보죠!! 🤗

Copy link
Contributor

@hsgo2430 hsgo2430 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드만 봐도 엄청 복잡한 기능인거같아요.
고생많으셨어요!

@Jokwanhee Jokwanhee merged commit 179295d into develop Nov 14, 2024
1 check passed
@Jokwanhee Jokwanhee deleted the feature/timetable_api_v3 branch December 10, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants