Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] 홈화면 키워드 알림 배너 AB테스트 #481

Merged
merged 8 commits into from
Nov 24, 2024

Conversation

wateralsie
Copy link
Contributor

@wateralsie wateralsie commented Nov 23, 2024

작업 내용

  • 홈화면에 키워드 알림 배너 추가 - 클릭시 키워드 관리 화면으로 이동
  • 배너에 AB테스트 추가

참고사항

  • StateFlow 값을 받아올 때 collect를 쓰면 초기값이 항상 먼저 넘어가더라고요 collectLatest를 사용해주세요!
  • 배포 일정이 촉박한지라 pr 반영 후 바로 배포 진행할 예정입니다

화면

@wateralsie wateralsie self-assigned this Nov 23, 2024
@wateralsie wateralsie requested a review from a team as a code owner November 23, 2024 02:15
@wateralsie wateralsie changed the title 홈화면 키워드 알림 배너 A/B테스트 추가 홈화면 키워드 알림 배너 AB테스트 Nov 23, 2024
@wateralsie wateralsie changed the title 홈화면 키워드 알림 배너 AB테스트 [Feature] 홈화면 키워드 알림 배너 AB테스트 Nov 23, 2024
Copy link
Member

@skdud0629 skdud0629 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요!

Copy link
Contributor

@ThirFir ThirFir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요!!!!!

@@ -149,6 +151,18 @@ class ArticleRepositoryImpl @Inject constructor(
}
}

override fun fetchKeywordNoti(): Flow<ArticleNoti> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헣 편할대로 하셔도 되는데 Flow 형태 지켜주셔서 감사합니다...

@wateralsie wateralsie merged commit fdcb31a into develop Nov 24, 2024
1 check passed
@wateralsie wateralsie deleted the feature/keyword-noti-abtest branch November 24, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants