Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] 전화하기 버튼 위치 A/B테스트 구현 #504

Merged
merged 10 commits into from
Dec 15, 2024
Merged

[Feature] 전화하기 버튼 위치 A/B테스트 구현 #504

merged 10 commits into from
Dec 15, 2024

Conversation

hsgo2430
Copy link
Contributor

요약

  • 전화하기 버튼 A/B 테스트 UI를 만들었습니다.
  • 전화번호란에서 전화하기 버튼 구현
  • 플러팅 버튼으로 전화하기버튼 구현

@hsgo2430 hsgo2430 requested a review from a team as a code owner December 11, 2024 08:01
Jokwanhee
Jokwanhee reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@Jokwanhee Jokwanhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했어요~ ☺️
몇 가지 커멘트 달아봤는데, 확인해주세요 🙇🏻

koin/src/main/java/in/koreatech/koin/ui/store/activity/StoreDetailActivity.kt Outdated Show resolved Hide resolved
koin/src/main/java/in/koreatech/koin/ui/store/activity/StoreDetailActivity.kt Outdated Show resolved Hide resolved
koin/src/main/java/in/koreatech/koin/ui/store/viewmodel/StoreDetailViewModel.kt Outdated Show resolved Hide resolved
koin/src/main/java/in/koreatech/koin/ui/store/viewmodel/StoreDetailViewModel.kt Outdated Show resolved Hide resolved
@hsgo2430 hsgo2430 self-assigned this Dec 12, 2024
nodobi
nodobi reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@nodobi nodobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요! 기존 코멘트에도 의견 남겨봤는데 한번 확인해주세요~! 😁

koin/src/main/res/layout/store_activity_detail.xml Show resolved Hide resolved
koin/src/main/java/in/koreatech/koin/ui/store/viewmodel/StoreDetailViewModel.kt Outdated Show resolved Hide resolved
@skdud0629 skdud0629 self-assigned this Dec 15, 2024
@skdud0629 skdud0629 merged commit 98e810d into develop Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThirFir ThirFir ThirFir left review comments

@nodobi nodobi nodobi left review comments

@skdud0629 skdud0629 skdud0629 approved these changes

@Jokwanhee Jokwanhee Jokwanhee approved these changes

Assignees

@hsgo2430 hsgo2430

@skdud0629 skdud0629

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hsgo2430 @nodobi @ThirFir @Jokwanhee @skdud0629