Skip to content

Commit

Permalink
refactor: 라인 포맷팅
Browse files Browse the repository at this point in the history
  • Loading branch information
Jang Jun Young committed Jun 25, 2024
1 parent b92add0 commit 55a7650
Show file tree
Hide file tree
Showing 4 changed files with 66 additions and 68 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ ResponseEntity<Void> deleteLand(
@SecurityRequirement(name = "Jwt Authentication")
@GetMapping("/admin/lands/{id}")
ResponseEntity<AdminLandResponse> getLand(
@PathVariable("id") Integer id
//@Auth(permit = {ADMIN}) Integer adminId
@PathVariable("id") Integer id,
@Auth(permit = {ADMIN}) Integer adminId
);

@ApiResponses(
Expand All @@ -106,8 +106,8 @@ ResponseEntity<AdminLandResponse> getLand(
@PutMapping("/admin/lands/{id}")
ResponseEntity<Void> updateLand(
@PathVariable("id") Integer id,
@RequestBody @Valid AdminLandRequest request
//@Auth(permit = {ADMIN}) Integer adminId
@RequestBody @Valid AdminLandRequest request,
@Auth(permit = {ADMIN}) Integer adminId
);

@ApiResponses(
Expand All @@ -122,7 +122,7 @@ ResponseEntity<Void> updateLand(
@SecurityRequirement(name = "Jwt Authentication")
@PostMapping("/admin/lands/{id}/undelete")
ResponseEntity<Void> undeleteLand(
@PathVariable("id") Integer id
//@Auth(permit = {ADMIN}) Integer adminId
@PathVariable("id") Integer id,
@Auth(permit = {ADMIN}) Integer adminId
);
}
Original file line number Diff line number Diff line change
Expand Up @@ -57,26 +57,26 @@ public ResponseEntity<Void> deleteLand(

@GetMapping("/admin/lands/{id}")
public ResponseEntity<AdminLandResponse> getLand(
@PathVariable("id") Integer id
//@Auth(permit = {ADMIN}) Integer adminId
@PathVariable("id") Integer id,
@Auth(permit = {ADMIN}) Integer adminId
) {
return ResponseEntity.ok().body(adminLandService.getLand(id));
}

@PutMapping("/admin/lands/{id}")
public ResponseEntity<Void> updateLand(
@PathVariable("id") Integer id,
@RequestBody @Valid AdminLandRequest request
//@Auth(permit = {ADMIN}) Integer adminId
@RequestBody @Valid AdminLandRequest request,
@Auth(permit = {ADMIN}) Integer adminId
) {
adminLandService.updateLand(id, request);
return ResponseEntity.ok().build();
}

@PostMapping("/admin/lands/{id}/undelete")
public ResponseEntity<Void> undeleteLand(
@PathVariable("id") Integer id
//@Auth(permit = {ADMIN}) Integer adminId
@PathVariable("id") Integer id,
@Auth(permit = {ADMIN}) Integer adminId
) {
adminLandService.undeleteLand(id);
return ResponseEntity.ok().build();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package in.koreatech.koin.admin.land.dto;


import java.util.List;

import static com.fasterxml.jackson.databind.PropertyNamingStrategies.SnakeCaseStrategy;
Expand Down
109 changes: 54 additions & 55 deletions src/test/java/in/koreatech/koin/admin/acceptance/AdminLandApiTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -78,32 +78,32 @@ void getLands() {
@DisplayName("관리자 권한으로 복덕방을 추가한다.")
void postLands() {
String jsonBody = """
{
"name": "금실타운",
"internal_name": "금실타운",
"size": "9.0",
"room_type": "원룸",
"latitude": "37.555",
"longitude": "126.555",
"phone": "041-111-1111",
"image_urls": ["http://image1.com", "http://image2.com"],
"address": "충청남도 천안시 동남구 병천면",
"description": "1년 계약시 20만원 할인",
"floor": 4,
"deposit": "30",
"monthly_fee": "200만원 (6개월)",
"charter_fee": "3500",
"management_fee": "21(1인 기준)",
"opt_closet": true,
"opt_tv": true,
"opt_microwave": true,
"opt_gas_range": false,
"opt_induction": true,
"opt_water_purifier": true,
"opt_air_conditioner": true,
"opt_washer": true
}
""";
{
"name": "금실타운",
"internal_name": "금실타운",
"size": "9.0",
"room_type": "원룸",
"latitude": "37.555",
"longitude": "126.555",
"phone": "041-111-1111",
"image_urls": ["http://image1.com", "http://image2.com"],
"address": "충청남도 천안시 동남구 병천면",
"description": "1년 계약시 20만원 할인",
"floor": 4,
"deposit": "30",
"monthly_fee": "200만원 (6개월)",
"charter_fee": "3500",
"management_fee": "21(1인 기준)",
"opt_closet": true,
"opt_tv": true,
"opt_microwave": true,
"opt_gas_range": false,
"opt_induction": true,
"opt_water_purifier": true,
"opt_air_conditioner": true,
"opt_washer": true
}
""";

User adminUser = userFixture.코인_운영자();
String token = userFixture.getToken(adminUser);
Expand Down Expand Up @@ -201,34 +201,34 @@ void getLand() {

JsonAssertions.assertThat(response.asPrettyString())
.isEqualTo(String.format("""

Check failure on line 203 in src/test/java/in/koreatech/koin/admin/acceptance/AdminLandApiTest.java

View workflow job for this annotation

GitHub Actions / JUnit Test Report

AdminLandApiTest.특정 복덕방 정보를 조회한다.

org.opentest4j.AssertionFailedError: expected: {"address"="가전리 123", "charter_fee"="1000", "deposit"=null, "description"="테스트용 복덕방", "floor"=null, "id"=1, "image_urls"=[], "internal_name"="금실타운", "is_deleted"=false, "latitude"="37.555", "longitude"="126.555", "management_fee"=null, "monthly_fee"="100", "name"="금실타운", "opt_air_conditioner"=false, "opt_closet"=false, "opt_gas_range"=false, "opt_induction"=false, "opt_microwave"=false, "opt_tv"=false, "opt_washer"=false, "opt_water_purifier"=false, "phone"=null, "room_type"="원룸", "size"=null} but was: {"address"="가전리 123", "charter_fee"="1000", "deposit"=null, "description"="테스트용 복덕방", "floor"=null, "id"=1, "image_urls"=[], "internal_name"="금실타운", "is_deleted"=false, "latitude"="37.555", "longitude"="126.555", "management_fee"=null, "monthly_fee"="100", "name"="금실타운", "opt_air_conditioner"=false, "opt_bed"=false, "opt_bidet"=false, "opt_closet"=false, "opt_desk"=false, "opt_electronic_door_locks"=false, "opt_elevator"=false, "opt_gas_range"=false, "opt_induction"=false, "opt_microwave"=false, "opt_refrigerator"=false, "opt_shoe_closet"=false, "opt_tv"=false, "opt_veranda"=false, "opt_washer"=false, "opt_water_purifier"=false, "phone"=null, "room_type"="원룸", "size"=null}
Raw output
org.opentest4j.AssertionFailedError: 
expected: {"address"="가전리 123", "charter_fee"="1000", "deposit"=null, "description"="테스트용 복덕방", "floor"=null, "id"=1, "image_urls"=[], "internal_name"="금실타운", "is_deleted"=false, "latitude"="37.555", "longitude"="126.555", "management_fee"=null, "monthly_fee"="100", "name"="금실타운", "opt_air_conditioner"=false, "opt_closet"=false, "opt_gas_range"=false, "opt_induction"=false, "opt_microwave"=false, "opt_tv"=false, "opt_washer"=false, "opt_water_purifier"=false, "phone"=null, "room_type"="원룸", "size"=null}
 but was: {"address"="가전리 123", "charter_fee"="1000", "deposit"=null, "description"="테스트용 복덕방", "floor"=null, "id"=1, "image_urls"=[], "internal_name"="금실타운", "is_deleted"=false, "latitude"="37.555", "longitude"="126.555", "management_fee"=null, "monthly_fee"="100", "name"="금실타운", "opt_air_conditioner"=false, "opt_bed"=false, "opt_bidet"=false, "opt_closet"=false, "opt_desk"=false, "opt_electronic_door_locks"=false, "opt_elevator"=false, "opt_gas_range"=false, "opt_induction"=false, "opt_microwave"=false, "opt_refrigerator"=false, "opt_shoe_closet"=false, "opt_tv"=false, "opt_veranda"=false, "opt_washer"=false, "opt_water_purifier"=false, "phone"=null, "room_type"="원룸", "size"=null}
	at java.base@17.0.11/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base@17.0.11/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base@17.0.11/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base@17.0.11/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
	at app//in.koreatech.koin.support.JsonAssertions$JsonStringAssert.isEqualTo(JsonAssertions.java:33)
	at app//in.koreatech.koin.admin.acceptance.AdminLandApiTest.getLand(AdminLandApiTest.java:203)
	at java.base@17.0.11/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base@17.0.11/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base@17.0.11/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base@17.0.11/java.lang.reflect.Method.invoke(Method.java:568)
	at app//org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:727)
	at app//org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
	at app//org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
	at app//org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:156)
	at app//org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:147)
	at app//org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:86)
	at app//org.junit.jupiter.engine.execution.InterceptingExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(InterceptingExecutableInvoker.java:103)
	at app//org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.lambda$invoke$0(InterceptingExecutableInvoker.java:93)
	at app//org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
	at app//org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
	at app//org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
	at app//org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
	at app//org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:92)
	at app//org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:86)
	at app//org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:217)
	at app//org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at app//org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:213)
	at app//org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:138)
	at app//org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:68)
	at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151)
	at app//org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at app//org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at app//org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at java.base@17.0.11/java.util.ArrayList.forEach(ArrayList.java:1511)
	at app//org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
	at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
	at app//org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at app//org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at app//org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at java.base@17.0.11/java.util.ArrayList.forEach(ArrayList.java:1511)
	at app//org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
	at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
	at app//org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at app//org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at app//org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at app//org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at app//org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:35)
	at app//org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
	at app//org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:54)
	at app//org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:107)
	at app//org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:88)
	at app//org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:54)
	at app//org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:67)
	at app//org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:52)
	at app//org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
	at app//org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
	at app//org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.processAllTestClasses(JUnitPlatformTestClassProcessor.java:119)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.access$000(JUnitPlatformTestClassProcessor.java:94)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor.stop(JUnitPlatformTestClassProcessor.java:89)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:62)
	at java.base@17.0.11/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base@17.0.11/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base@17.0.11/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base@17.0.11/java.lang.reflect.Method.invoke(Method.java:568)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
	at jdk.proxy1/jdk.proxy1.$Proxy2.stop(Unknown Source)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker$3.run(TestWorker.java:193)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:129)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:100)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:60)
	at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
	at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:113)
	at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:65)
	at app//worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
	at app//worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)
{
"id": %d,
"name": "금실타운",
"internal_name": "금실타운",
"size": null,
"room_type": "원룸",
"latitude": "37.555",
"longitude": "126.555",
"phone": null,
"image_urls": [],
"address": "가전리 123",
"description": "테스트용 복덕방",
"floor": null,
"deposit": null,
"monthly_fee": "100",
"charter_fee": "1000",
"management_fee": null,
"opt_closet": false,
"opt_tv": false,
"opt_microwave": false,
"opt_gas_range": false,
"opt_induction": false,
"opt_water_purifier": false,
"opt_air_conditioner": false,
"opt_washer": false,
"is_deleted": false
}
""", landId));
{
"id": %d,
"name": "금실타운",
"internal_name": "금실타운",
"size": null,
"room_type": "원룸",
"latitude": "37.555",
"longitude": "126.555",
"phone": null,
"image_urls": [],
"address": "가전리 123",
"description": "테스트용 복덕방",
"floor": null,
"deposit": null,
"monthly_fee": "100",
"charter_fee": "1000",
"management_fee": null,
"opt_closet": false,
"opt_tv": false,
"opt_microwave": false,
"opt_gas_range": false,
"opt_induction": false,
"opt_water_purifier": false,
"opt_air_conditioner": false,
"opt_washer": false,
"is_deleted": false
}
""", landId));
}

@Test
Expand Down Expand Up @@ -336,5 +336,4 @@ void undeleteLand() {
});
}


}

0 comments on commit 55a7650

Please sign in to comment.