refactor: 많이 조회한 게시글 키워드 구조 변경 #1061
Open
+411
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20HyeonsuLee
requested changes
Dec 30, 2024
kih1015
approved these changes
Feb 19, 2025
Comment on lines
+15
to
+45
| @Component | ||
| @RequiredArgsConstructor | ||
| public class KeywordRankingManager { | ||
|
|
||
| private final PopularKeywordTracker popularKeywordTracker; | ||
| private final ArticleSearchKeywordRepository keywordRepository; | ||
|
|
||
| public List<String> getTopKeywords(int count) { | ||
| List<String> primaryKeywords = new ArrayList<>(popularKeywordTracker.getTopKeywords(count)); | ||
|
|
||
| if (primaryKeywords.size() < count) { | ||
| int remainingCount = count - primaryKeywords.size(); | ||
| List<String> secondaryKeywords = getBackupKeywords(remainingCount); | ||
| secondaryKeywords.stream() | ||
| .filter(keyword -> !primaryKeywords.contains(keyword)) | ||
| .forEach(primaryKeywords::add); | ||
| } | ||
|
|
||
| return primaryKeywords; | ||
| } | ||
|
|
||
| private List<String> getBackupKeywords(int count) { | ||
| LocalDateTime fromDate = LocalDateTime.now().minusWeeks(1); | ||
| Pageable pageable = PageRequest.of(0, count); | ||
|
|
||
| List<String> topKeywords = keywordRepository.findTopKeywords(fromDate, pageable); | ||
| if (topKeywords.isEmpty()) { | ||
| topKeywords = keywordRepository.findTopKeywordsByLatest(pageable); | ||
| } | ||
| return topKeywords; | ||
| } |
There was a problem hiding this comment.
클래스 갯수가 늘어나더라도 크기를 작게 분리하는 것이 유지보수에 많은 도움이 된다고 생각합니다. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항