feat: 도커파일 추가 #445
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| FROM openjdk:17-slim | ||
| WORKDIR /app | ||
| VOLUME /tmp | ||
|
There was a problem hiding this comment. R/tmp 경로 말고 적절한 위치 없을까요? linux의 /tmp 경로는 말 그대로 /usr/local 어딘가에 좋은 위치는 없을까요? There was a problem hiding this comment. 음 이미지는 빌드후 삭제시켜도 무방한 이미지라 tmp에 넣어두었는데, 그렇다면 There was a problem hiding this comment. 그리고 tmp라고 저장할경우 실제 저장되는 위치는 var/lib/jenkins/workspace에서의 tmp가 위치입니다. There was a problem hiding this comment. 즉 따로 동기화할만한 데이터가 없으면 없애도 무방하다는 입장입니다 |
||
| ADD /var/lib/jenkins/workspace/KOIN_API_V2_STAGE/build/libs/KOIN_API_V2.jar /app/app.jar | ||
| ENV JAVA_OPTS="" | ||
|
There was a problem hiding this comment. 아 env는 혹시나 추후 디버깅할때 쓸까봐 넣었어요 |
||
| ENTRYPOINT ["java", "-jar", "/app/app.jar"] | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slim으로 한 이유가 있나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음... 이미지 크기 줄일려고 slim으로 설정
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저는 갠적으로 amazoncorretto:17 좋아해요
aws 꺼라서 호환이슈에서 조금 안정적인 느낌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네 반영하겠습니다~