feat: 도커파일 추가 #445
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,6 @@ | ||||||||||||||||||||||||||||||
| # 사용할 Java 버전 지정 | ||||||||||||||||||||||||||||||
| FROM amazoncorretto:17 | ||||||||||||||||||||||||||||||
| WORKDIR /app | ||||||||||||||||||||||||||||||
| VOLUME /tmp | ||||||||||||||||||||||||||||||
| ADD ./build/libs/KOIN_API_V2.jar /app/app.jar | ||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. CCOPY 말고 ADD를 사용한 이유가 있나요? There was a problem hiding this comment. 맞는 말씀입니다 Copy가 조금더 적합할것 같습니다! |
||||||||||||||||||||||||||||||
| ENTRYPOINT ["java", "-jar", "/app/app.jar"] | ||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. A어떤 역할을 하는지 간단하게 설명해주실 수 있을까요? There was a problem hiding this comment. 흠 From은 이미지를 자바17로 돌린다는 소리고요 There was a problem hiding this comment. C가독성을 위해 개행을 추가해주면 좋을 것 같아요
Suggested change
There was a problem hiding this comment. 넵 적용하겠습니다..! |
||||||||||||||||||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R
/tmp 경로 말고 적절한 위치 없을까요?
linux의 /tmp 경로는 말 그대로
임시파일이 위치하는 경로입니다.없어져도 무관한 경로라서 가끔 몇몇 OS에서는 system cron으로 30일 뒤에 공간을 비운다는 등의 작업을 수행한다고도 하네요
/usr/local 어딘가에 좋은 위치는 없을까요?
참고자료: https://coding-panda.com/%EB%A6%AC%EB%88%85%EC%8A%A4-%EC%A3%BC%EC%9A%94-%EB%94%94%EB%A0%89%ED%86%A0%EB%A6%AC-%EB%B3%84-%EC%97%AD%ED%95%A0-%EB%B0%8F-%EC%84%A4%EB%AA%85/#tmp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음 이미지는 빌드후 삭제시켜도 무방한 이미지라 tmp에 넣어두었는데, 그렇다면
그냥 생략해도 무방할것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그리고 tmp라고 저장할경우 실제 저장되는 위치는 var/lib/jenkins/workspace에서의 tmp가 위치입니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
즉 따로 동기화할만한 데이터가 없으면 없애도 무방하다는 입장입니다