Skip to content

refactor: 채팅 메시지 최대 길이 설정 #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanooGwan merged 4 commits into from
Jan 29, 2026
+5 −2
Merged

refactor: 채팅 메시지 최대 길이 설정 #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
07f396c
refactor: 채팅 전송 DTO 수정
JanooGwan Jan 28, 2026
5ddcb6d
refactor: Entity에 제약조건 추가
JanooGwan Jan 28, 2026
735b93b
feat: 마이그레이션 SQL문 작성
JanooGwan Jan 29, 2026
4b64823
refactor: ChatRoom의 lastMessageContent 최대 길이(1000자) 변경
JanooGwan Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/gg/agit/konect/domain/chat/dto/ChatMessageSendRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@

import io.swagger.v3.oas.annotations.media.Schema;
import jakarta.validation.constraints.NotBlank;
import jakarta.validation.constraints.Size;

public record ChatMessageSendRequest(
@NotBlank(message = "메시지 내용은 필수입니다.")
@Size(max = 1000, message = "1000자 이내로 입력해주세요.")
@Schema(description = "메시지 내용", example = "투명 케이스가 끼워져 있었어요!", requiredMode = REQUIRED)
String content
) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/gg/agit/konect/domain/chat/model/ChatMessage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public class ChatMessage extends BaseEntity {
private Integer id;

@NotNull
@Column(name = "content", nullable = false, columnDefinition = "TEXT")
@Column(name = "content", nullable = false, length = 1000)
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엔티티 정의를 TEXT에서 VARCHAR(1000)으로 변경했지만, 데이터베이스 마이그레이션 스크립트가 포함되지 않았습니다. Flyway를 사용하는 프로젝트이므로, src/main/resources/db/migration/ 디렉토리에 새로운 마이그레이션 파일(예: V17__alter_chat_message_content_length.sql)을 추가하여 실제 데이터베이스 스키마도 변경해야 합니다.

마이그레이션 스크립트 예시:
ALTER TABLE chat_message MODIFY COLUMN content VARCHAR(1000) NOT NULL;

Suggested change
@Column(name = "content", nullable = false, length = 1000)
@Column(name = "content", nullable = false, columnDefinition = "TEXT")

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChatMessage의 content 필드에 1000자 제한을 추가했지만, ChatRoom.lastMessageContent 필드는 여전히 TEXT 타입으로 정의되어 있습니다. ChatService.sendMessage() 메서드(line 113)에서 chatRoom.updateLastMessage(chatMessage.getContent(), ...)를 통해 ChatMessage의 content가 lastMessageContent로 복사되므로, 일관성을 위해 ChatRoom.lastMessageContent도 같은 길이 제한(length = 1000)을 적용해야 합니다.

Copilot uses AI. Check for mistakes.
private String content;

@Column(name = "is_read", nullable = false)
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/gg/agit/konect/domain/chat/model/ChatRoom.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public class ChatRoom extends BaseEntity {
@Column(name = "id", nullable = false, updatable = false, unique = true)
private Integer id;

@Column(name = "last_message_content", columnDefinition = "TEXT")
@Column(name = "last_message_content", length = 1000)
private String lastMessageContent;

@Column(name = "last_message_sent_at")
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/db/migration/V17__alter_chat_message_content_length.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ALTER TABLE chat_message MODIFY COLUMN content VARCHAR(1000) NOT NULL;
Loading