Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering timeseries by property data #249

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Allow filtering timeseries by property data #249

merged 4 commits into from
Jul 10, 2024

Conversation

lafrech
Copy link
Contributor

@lafrech lafrech commented Jul 10, 2024

Require bemserver-core >= 18.0.1

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.

Project coverage is 99.28%. Comparing base (5fb73ee) to head (5e7e067).

Files Patch % Lines
src/bemserver_api/extensions/smorest.py 80.95% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   99.36%   99.28%   -0.08%     
==========================================
  Files         192      192              
  Lines        4721     4756      +35     
  Branches     1630     1637       +7     
==========================================
+ Hits         4691     4722      +31     
- Misses         15       17       +2     
- Partials       15       17       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lafrech lafrech merged commit a3c9684 into main Jul 10, 2024
6 of 8 checks passed
@lafrech lafrech deleted the ts_by_prop_data branch July 10, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant