Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gcbrain crash when PLANT_HAS_PART #108

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

dzmitry-rudnouski
Copy link

Talk to gcbrain when PLANT_HAS_PART - there is no reply from gcbrain and game crashes after selecting any option:
scr00000
SLOT08.zip

Here is fix.

@burner1024
Copy link
Member

burner1024 commented Jan 10, 2023

Better switch to using proper defines instead of giq_ and magic numbers.
Why is the ANKH_GIVEN condition commented out?
There's no default Reply after Reply(611), so either its condition is unnecessary, or a reply would be missing in some cases.

@dzmitry-rudnouski
Copy link
Author

Corrected.

@burner1024
Copy link
Member

What about condition?

@dzmitry-rudnouski
Copy link
Author

ANKH_GIVEN condition is not commented anymore.
Default option after Reply(611) is NOption(233,Node999,004);

@burner1024
Copy link
Member

I mean, why do we need

   else if (global_var(GVAR_VAULT_GECKO_PLANT) < PLANT_REPAIRED) then begin
      Reply(611);

rathen than just

   else begin
      Reply(611);

?

@dzmitry-rudnouski
Copy link
Author

Yes, you are right, corrected.

@dzmitry-rudnouski
Copy link
Author

One more crash, now in Node003.
SLOT09.zip
Will be fixed in next commits.

burner1024 added a commit to BGforgeNet/Fallout2_Restoration_Project that referenced this pull request Feb 22, 2024
@burner1024 burner1024 merged commit 6db3823 into BGforgeNet:master Feb 22, 2024
1 check passed
@dzmitry-rudnouski dzmitry-rudnouski deleted the gcbrain_crash branch October 24, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants