-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Priority Types For Push #393
base: develop
Are you sure you want to change the base?
Conversation
…HoM_Adapter-#390-AddPriorityTypesForPush
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good initial work @GCRA101 , but I think this can be simplified quite a bit.
Also, think this should be used for exceptional cases where the dependency sorting is not enough so you don't have to add all types in to the priority types, but just the ones that really needs to go before everything else, and is not already handled by the dependency sorting.
Please see comments.
Had a look at this PR and the ETABS one. Great work @GCRA101 ! 🚀 |
Co-authored-by: Isak Näslund <isak.naslund@burohappold.com>
Co-authored-by: Isak Näslund <isak.naslund@burohappold.com>
…ithub.com/BHoM/BHoM_Adapter into BHoM_Adapter-#390-AddPriorityTypesForPush
After removal of PriorityComparer class Co-authored-by: Isak Näslund <isak.naslund@burohappold.com>
… from Algorithm based on Dependencies Co-authored-by: Isak Näslund <isak.naslund@burohappold.com>
Co-authored-by: Isak Näslund <isak.naslund@burohappold.com>
…ithub.com/BHoM/BHoM_Adapter into BHoM_Adapter-#390-AddPriorityTypesForPush
@IsakNaslundBh, @alelom, |
Requested changes now addressed and happy with this from a code perspective. Dismissing my request for change review
Happy with this from a code perspective now, and have dismissed my review. @Chrisshort92 Could you please assist in testing this from a functionality point of view? |
NOTE: Depends on
BHoM/ETABS_Toolkit#480
Issues addressed by this PR
Closes #390
BHoM_Adapter now equipped with a new attribute PropertyTypes defining priority order for the push of objects into software packages in addition to DependencyTypes. This change has been required due to the requirements from software packages like ETABS to push objects following a specific hierarchy.
Test files
Video Demonstration - Issue
https://burohappold.sharepoint.com/:v:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23480-AddPriorityTypesForPush/Push%20Levels%20Issue.mp4?csf=1&web=1&e=7cEacd
Video Demonstration - Solution
https://burohappold.sharepoint.com/:v:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23480-AddPriorityTypesForPush/Push%20Levels%20Sorted.mp4?csf=1&web=1&e=cDUbje
Json File
https://burohappold.sharepoint.com/sites/BHoM/_layouts/15/download.aspx?UniqueId=aa695dbddee44123b35aecc6843d658a&e=mvnMou
Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23480-AddPriorityTypesForPush/Test%20Script.gh?csf=1&web=1&e=Lzfzec
Etabs File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23480-AddPriorityTypesForPush/Test%20ETABS%20Model.EDB?csf=1&web=1&e=lj7JY7
Changelog