Versioning_Engine - Add support for versioning chains #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecler
requested review from
al-fisher,
FraserGreenroyd,
IsakNaslundBh and
kThorsager
There was a problem hiding this comment.
Have looked at the code, I see no problems with it. Have not yet tested in conjunction with the Versioning_Toolkit PR at this stage though, so will not yet approve (but am happy to if needed) in case someone else gets chance to review before I get round to doing both
kThorsager
approved these changes
Feb 13, 2020
|
/azp run BHoM_Engine.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Engine part of BHoM/Versioning_Toolkit#20
See BHoM/Versioning_Toolkit#21 for more details.
Notice that the changes are on two levels:
ToNewVersionmethod now takes an extra parameter: the version to run the upgrade on. This way, the upgrader can now call each other.