Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlipBar, Moments and other fixes #254

Merged
merged 21 commits into from
Feb 4, 2020

Conversation

kThorsager
Copy link
Contributor

@kThorsager kThorsager commented Jan 24, 2020

Issues addressed by this PR

Closes #156
Fixed by adding warnings when pushing unstable releases. The warning outline why the release was unstable but does not stop the bar from being pushed. The release is then set as ETABS default fix fix.
Closes #232
Fixed by flipping the bar before ETABS gets the chance to. (but actually handling the asymmetric properties)
Residual issue is that asymmetric sections can't be mirrored in ETABS API, raised in #253
Closes #239
Closes #249
Closes #252

Test files

https://burohappold.sharepoint.com/:u:/s/BHoM/EQS3iMoVy-1NtG9g1powvwMBAHCMpXf9frWfX42K-OmwyQ?e=N9EnZI

Changelog

  • Fixes unpredictable bar behaviour due to ETABS flipping them upon creation
  • Adds warnings when pushing unstable Bar Releases
  • Adds feature to push BarUniformlyDistributedLoad with moments
  • Fixes pushing ExplicitSection
  • Fixes Pushing Offsets with displacement along the X-axis

Additional comments

@kThorsager kThorsager added type:bug Error or unexpected behaviour type:feature New capability or enhancement status:WIP PR in progress and still in draft, not ready for formal review labels Jan 24, 2020
@kThorsager kThorsager self-assigned this Jan 24, 2020
@kThorsager kThorsager marked this pull request as ready for review January 24, 2020 14:18
@kThorsager kThorsager removed the status:WIP PR in progress and still in draft, not ready for formal review label Jan 24, 2020
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genral looking great. Really good to have comments explaining why things are failing! A small comment on method name of flip bar and some pre-existing bug that needs fixing for explicit section.

Also added comment about the releases, to double check that the Etabs conventions and BHoM conventions are converted correctly.

And finally, still unchecked, is that the direction of especially Mz is correct.

ETABS_Engine/Query/FlipBar.cs Outdated Show resolved Hide resolved
Etabs_Adapter/CRUD/Create/Bar.cs Outdated Show resolved Hide resolved
ETABS_Engine/Modify/FlipEndPoints.cs Outdated Show resolved Hide resolved
ETABS_Engine/Convert/ToCSI.cs Show resolved Hide resolved
@kThorsager
Copy link
Contributor Author

Completely right @IsakNaslundBh , releases have been fixed (should that be logged somewhere?) and Explicit section is actually fixed now, and the bars orientation behaves

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! general nice improvements and good to get explicit error messaging of what is malfunctioning (when it does)

@IsakNaslundBh IsakNaslundBh merged commit bbc3c3f into master Feb 4, 2020
@IsakNaslundBh IsakNaslundBh deleted the ETABS_Toolkit-232-BarFlips-MomentLoad-Releases branch February 4, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour type:feature New capability or enhancement
Projects
None yet
2 participants