-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FlipBar, Moments and other fixes #254
FlipBar, Moments and other fixes #254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Genral looking great. Really good to have comments explaining why things are failing! A small comment on method name of flip bar and some pre-existing bug that needs fixing for explicit section.
Also added comment about the releases, to double check that the Etabs conventions and BHoM conventions are converted correctly.
And finally, still unchecked, is that the direction of especially Mz is correct.
Completely right @IsakNaslundBh , releases have been fixed (should that be logged somewhere?) and Explicit section is actually fixed now, and the bars orientation behaves |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now! general nice improvements and good to get explicit error messaging of what is malfunctioning (when it does)
Issues addressed by this PR
Closes #156
Fixed by adding warnings when pushing unstable releases. The warning outline why the release was unstable but does not stop the bar from being pushed. The release is then set as ETABS default fix fix.
Closes #232
Fixed by flipping the bar before ETABS gets the chance to. (but actually handling the asymmetric properties)
Residual issue is that asymmetric sections can't be mirrored in ETABS API, raised in #253
Closes #239
Closes #249
Closes #252
Test files
https://burohappold.sharepoint.com/:u:/s/BHoM/EQS3iMoVy-1NtG9g1powvwMBAHCMpXf9frWfX42K-OmwyQ?e=N9EnZI
Changelog
Bar
Releases
BarUniformlyDistributedLoad
with momentsExplicitSection
Offsets
with displacement along the X-axisAdditional comments