ETABS_Toolkit: SelectionRequest, Delete and update for Node #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well I'm confused @IsakNaslundBh @FraserGreenroyd ? EDIT: about the CI issues which has been resolved now |
IsakNaslundBh
approved these changes
Jul 6, 2020
|
/azp run ETABS_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
IsakNaslundBh
deleted the
Geometry_Engine-minor-method-additions-and-updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
For the coordinateSystem comparison
BHoM/BHoM_Engine#1880
Issues addressed by this PR
Closes #329
Closes #315
Adds warnings related to #311
Also adds Delete
Also some extra code due to this BHoM/BHoM_Adapter#239
And note that Update Node is slow, as I can't find any way to lock ETABS or any batch move (as every node can move in a different direction) and it does also move the things it's connected to, which might be what one would expect?
Test files
https://burohappold.sharepoint.com/:u:/s/BHoM/EchZkdNbgr9Eo7hkicvBPKYBVch1ZVDE16SxE1Fd6HGxQA?e=k2BOcX
https://burohappold.sharepoint.com/:u:/s/BHoM/EcsGb6NIFDdAoQL4FJKzGp4B5PHm4mKI7Uj842pIQXf6Uw?e=gPlfdt
Changelog
Additional comments