Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null handling in FEMesh #385

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

JosefTaylor
Copy link
Contributor

@JosefTaylor JosefTaylor commented Jul 29, 2021

NOTE: Depends on

Issues addressed by this PR

Closes #384

Also related to #352

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23385-fix-FEMesh-read-method?csf=1&web=1&e=1WOL2g

Changelog

Additional comments

@JosefTaylor JosefTaylor self-assigned this Jul 29, 2021
@JosefTaylor JosefTaylor added the type:bug Error or unexpected behaviour label Jul 29, 2021
@JosefTaylor
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 29, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • core

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@JosefTaylor
Copy link
Contributor Author

/azp run ETABS_Toolkit.CheckCore

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

@mchaf mchaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, king

@JosefTaylor JosefTaylor merged commit 359f54e into master Aug 3, 2021
@JosefTaylor JosefTaylor deleted the ETABS_Toolkit-#384-fix-FEMesh-read-method branch August 3, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading FE mesh fails when mesh has 'None' property or has no nodes/faces
2 participants