Enable pushing surface-based ModelInstances #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelbaran
requested review from
rwemay,
al-fisher,
adecler,
IsakNaslundBh and
epignatelli
pawelbaran
changed the title
This was referenced Nov 12, 2019
FraserGreenroyd
approved these changes
Nov 15, 2019
al-fisher
approved these changes
Nov 16, 2019
There was a problem hiding this comment.
Thanks @pawelbaran - this in itself is a great addition :
Noting throughout my testing a number of edge cases - which you have already highlighted in PRs I think pretty comprehensively. So am happy we can merge and then raise further issues and priorities as needed. 🚀
al-fisher
deleted the
BHoM-Issue425-CreationOfTrimmedNurbsSurfaceDefinition
branch
This was referenced Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
#603
#1319
Issues addressed by this PR
Closes #408
Test files
Test files are located on SharePoint. To run it, please switch to the branches related to the following PRs:
Changelog
BH.Engine.Adapters.Revit.Create.ModelInstance()methods were added for locations of typeISurfaceandISolidModelInstancewith location of typeISurfaceorISolidto a Brep-based DirectShape has been added together with necessary helper methodsAdditional comments
Please see #603.
Push does not work for closed or periodic surfaces because they are not supported by Revit.
Issues to be raised after merging this:
ToRevitCurvesandToRevitCurveArraymethods into oneSphere,Coneetc.) to Revit