[WIP] Direct current deposition: constant-memory shape factors#6705
Open
RemiLehe wants to merge 1 commit intoBLAST-WarpX:developmentfrom
Open
[WIP] Direct current deposition: constant-memory shape factors#6705RemiLehe wants to merge 1 commit intoBLAST-WarpX:developmentfrom
RemiLehe wants to merge 1 commit intoBLAST-WarpX:developmentfrom
Conversation
…ethod Use pre-computed polynomial coefficients stored in GPU constant memory (for CUDA) instead of evaluating shape factor formulas with if-constexpr branches. Shape factors are now computed on-the-fly in the deposition loops via Horner's method, eliminating all intermediate shape factor arrays. This reduces register pressure on GPU and enables faster access through constant memory. Inspired by Hi-PACE++ PR BLAST-WarpX#1328. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
Tests on Perlmutter's A100 did not seem to give a speedup. Here are the timings for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if constexprshape factor evaluation in the direct current deposition kernel (doDepositionShapeNKernel) with a table-driven Horner's method approachTest plan
test_3d_langmuir_multi_nodalpasses (run + analysis + checksum), confirming numerical equivalence with the original implementation🤖 Generated with Claude Code