Clean-up: moved current correction print statement inside PSATD solver condition#6721
Open
oshapoval wants to merge 1 commit intoBLAST-WarpX:developmentfrom
Open
Clean-up: moved current correction print statement inside PSATD solver condition#6721oshapoval wants to merge 1 commit intoBLAST-WarpX:developmentfrom
oshapoval wants to merge 1 commit intoBLAST-WarpX:developmentfrom
Conversation
Member
|
Thanks, @oshapoval. Answering this,
I proposed a way to improve this in #6183, but it hasn't been received positively, so I left it there. See, in particular, #6183 (comment). The rationale behind #6183 was indeed to make the backend (the code) more maintainable and the frontend (the printed output) more polished, which sounds similar to what you commented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the runtime output table by moving the current correction print statement inside the PSATD solver condition. It can be merged as a quick fix, but we may want to consider how to reorganize or improve this output.