Feat iaso connection nf #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarfil
force-pushed
the
feat-iaso_connection-nf
branch
3 times, most recently
from
2da8763 to
883d95a
Compare
….Session and avoid reading env vars
nazarfil
force-pushed
the
feat-iaso_connection-nf
branch
from
ed9e772 to
3ae2c11
Compare
nazarfil
force-pushed
the
feat-iaso_connection-nf
branch
from
3ae2c11 to
7f5dd00
Compare
nazarfil
force-pushed
the
feat-iaso_connection-nf
branch
from
4af6343 to
765076c
Compare
nazarfil
force-pushed
the
feat-iaso_connection-nf
branch
from
b53e721 to
bc414f8
Compare
qgerome
requested changes
Jun 10, 2024
nazarfil
force-pushed
the
feat-iaso_connection-nf
branch
from
d779f71 to
460a147
Compare
nazarfil
force-pushed
the
feat-iaso_connection-nf
branch
from
25fa62e to
b6be97c
Compare
qgerome
requested changes
Jun 10, 2024
…ntiation in IASO module
qgerome
requested changes
Jun 12, 2024
openhexa/toolbox/iaso/iaso.py
Outdated
| raise ValueError("Values for org_units and projects cannot be empty lists") | ||
| params = kwargs | ||
| params.update({"page": page, "limit": limit, "org_units": org_units, "projects": projects}) | ||
| response = self.api_client.request("POST", "/api/forms", data=params) |
There was a problem hiding this comment.
All the methods are available on the Session object.
Suggested change
| response = self.api_client.request("POST", "/api/forms", data=params) | |
| response = self.api_client.post("/api/forms", data=params) |
openhexa/toolbox/iaso/iaso.py
Outdated
| params.update({"page": page, "limit": limit}) | ||
| if as_dataframe: | ||
| params.update({"csv": "true"}) | ||
| response = self.api_client.request("GET", "/api/instances", params=params) |
There was a problem hiding this comment.
Suggested change
| response = self.api_client.request("GET", "/api/instances", params=params) | |
| response = self.api_client.get("/api/instances", params=params) |
openhexa/toolbox/iaso/iaso.py
Outdated
| response = self.api_client.request("GET", "/api/instances", params=params) | ||
| forms = pl.read_csv(io.StringIO(response.content.decode("utf-8")))[dataframe_columns] | ||
| return forms | ||
| response = self.api_client.request("GET", "/api/instances/", params=kwargs) |
There was a problem hiding this comment.
Suggested change
| response = self.api_client.request("GET", "/api/instances/", params=kwargs) | |
| response = self.api_client.get("/api/instances/", params=kwargs) |
openhexa/toolbox/iaso/iaso.py
Outdated
| """ | ||
| params = kwargs | ||
| params.update({"page": page, "limit": limit}) | ||
| response = self.api_client.request("GET", "/api/orgunits", params=kwargs) |
There was a problem hiding this comment.
Suggested change
| response = self.api_client.request("GET", "/api/orgunits", params=kwargs) | |
| response = self.api_client.get("/api/orgunits", params=params) |
There was a problem hiding this comment.
params=kwargs works since you just copy the reference into params and update the dictionary in-place (and thus the kwargs object) but I would prefer to update the kwargs directly OR using params here.
openhexa/toolbox/iaso/iaso.py
Outdated
|
|
||
| params = kwargs | ||
| params.update({"page": page, "limit": limit}) | ||
| response = self.api_client.request("GET", "/api/projects", params=params) |
There was a problem hiding this comment.
Suggested change
| response = self.api_client.request("GET", "/api/projects", params=params) | |
| response = self.api_client.get("/api/projects", params=params) |
nazarfil
force-pushed
the
feat-iaso_connection-nf
branch
2 times, most recently
from
eb9a855 to
33d405d
Compare
nazarfil
force-pushed
the
feat-iaso_connection-nf
branch
from
33d405d to
f9405ac
Compare
qgerome
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates IASO API client as module to fetch
https://bluesquare.atlassian.net/jira/software/c/projects/HEXA/boards/330?selectedIssue=HEXA-963