-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: measure CPU time of VBox apps correctly #5867
Conversation
We were checking for VBoxSVC.exe and, if a VBox app is running, counting its CPU time as BOINC-related. Should be 'VBoxHeadless.exe' on Win. May be different on Mac/Linux, so use '*vbox*', case-insensitive
Not all vbox processes are necessarily BOINC related.
Thus, only those processes should be included that are in the BOINC process tree. |
@davidpanderson, please fix Windows build |
The VBoxHeadless.exe processes are in the VBoxSVC.exe process tree, the BOINC client tree. In any case: the only thing this affects is the "suspend if non-BOINC CPU usage exceeds X" pref, |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5867 +/- ##
============================================
+ Coverage 10.51% 10.75% +0.23%
Complexity 1068 1068
============================================
Files 280 280
Lines 36021 36552 +531
Branches 8441 8471 +30
============================================
+ Hits 3789 3930 +141
- Misses 31843 32233 +390
Partials 389 389
|
@computezrmle, could this be later better handled with the new functionality introduced in #5870? |
We were checking for VBoxSVC.exe and, if a VBox app is running, counting its CPU time as BOINC-related.
Should be 'VBoxHeadless.exe' on Win.
May be different on Mac/Linux, so use 'vbox', case-insensitive