make PropKey methods public #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #20 +/- ##
=====================================
Coverage 0.0% 0.0%
=====================================
Files 17 17
Lines 3157 3157
=====================================
Misses 3157 3157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dr-orlovsky
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
ACK d4394ce
We actually need to make all of the methods pub. The reason they are not is that before it was a trait over external-type Psbt from rust-bitcoin, which is public by default.
|
Ok, I will update the PR then |
zoedberg
force-pushed
the
mpc_entropy_pub
branch
from
d4394ce
to
48df55f
Compare
zoedberg
changed the title
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
PropKey::mpc_entropy()public, needed to avoid manually recreating the proprietary key using constants before converting it to a rust-bitcoin proprietary key.