Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: underflow when parsing DerivationSeg #21

Merged

Conversation

whfuyn
Copy link
Contributor

@whfuyn whfuyn commented Feb 22, 2024

$ ./rgb create test1 --tapret-key-only "[9ae0796a/86h/1h/0h]tpubDDGrVg19xRy5D9x8i1ai9on1Dzn7
Pg4nTTPJw7EkPcS9rQC6w3dxHSQHH3LCfApqovuJxtzyFrAVDY86STx1eh8aERV75FRcu7wY7wH9QWp/0/*"
thread 'main' panicked at /home/_/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bp-derive-0.11.0-beta.3/src/path.rs:136:23:
attempt to subtract with overflow
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

--tapret-key-only is obtained from bitcoin-cli.
Not sure if it's the correct way to create a wallet, but after fixing this panic, the wallet is created successfully.

@dr-orlovsky
Copy link
Member

Very good catch, thank you!

@dr-orlovsky dr-orlovsky merged commit cea8444 into BP-WG:master Feb 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants