Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve XprivAccount APIs #36

Merged
merged 9 commits into from
Aug 26, 2024
Merged

Improve XprivAccount APIs #36

merged 9 commits into from
Aug 26, 2024

Conversation

dr-orlovsky
Copy link
Member

No description provided.

@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Aug 21, 2024
@dr-orlovsky dr-orlovsky self-assigned this Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 85.21739% with 17 lines in your changes missing coverage. Please review.

Project coverage is 42.6%. Comparing base (82a9b01) to head (8faa3bc).
Report is 12 commits behind head on master.

Files Patch % Lines
derive/src/xkey.rs 84.0% 17 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master     #36     +/-   ##
========================================
+ Coverage    36.8%   42.6%   +5.8%     
========================================
  Files          24      24             
  Lines        4153    4233     +80     
========================================
+ Hits         1528    1802    +274     
+ Misses       2625    2431    -194     
Flag Coverage Δ
rust 42.6% <85.2%> (+5.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky
Copy link
Member Author

@zoedberg I assume I can merge it?

Copy link
Contributor

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this can be merged. Thanks

@dr-orlovsky dr-orlovsky merged commit 04a7a2b into master Aug 26, 2024
27 checks passed
@dr-orlovsky dr-orlovsky deleted the xkey branch September 5, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants