Skip to content

feat: Chat scroll performance optimization with configurable placeholder sensitivity #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BP602 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Chat scroll performance optimization with configurable placeholder sensitivity #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 59 additions & 1 deletion src/renderer/src/components/Dialogs/Settings/Sections/General.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { InfoIcon, CaretDownIcon, FolderOpen } from "@phosphor-icons/react";
import ColorPicker from "../../../Shared/ColorPicker";
import NotificationFilePicker from "../../../Shared/NotificationFilePicker";
import clsx from "clsx";
import { DEFAULT_CHAT_HISTORY_LENGTH } from "@utils/constants";
import { DEFAULT_CHAT_HISTORY_LENGTH, DEFAULT_SCROLL_SEEK_VELOCITY } from "@utils/constants";

const GeneralSection = ({ settingsData, onChange }) => {
return (
Expand Down Expand Up @@ -314,6 +314,9 @@ const GeneralSection = ({ settingsData, onChange }) => {
};

const ChatroomSection = ({ settingsData, onChange }) => {
const scrollSeekVelocity =
settingsData?.chatrooms?.scrollSeekVelocityThreshold ?? DEFAULT_SCROLL_SEEK_VELOCITY;

return (
<div className="settingsContentSection">
<div className="settingsSectionHeader">
Expand Down Expand Up @@ -389,6 +392,61 @@ const ChatroomSection = ({ settingsData, onChange }) => {
/>
</div>
</div>
<div className="settingsItem">
<div
className={clsx("settingSwitchItem", {
active: scrollSeekVelocity !== DEFAULT_SCROLL_SEEK_VELOCITY,
})}>
<div className="settingsItemTitleWithInfo">
<span className="settingsItemTitle">
Scroll Placeholder Sensitivity
<span
style={{
marginLeft: 8,
fontSize: 12,
opacity: 0.7,
}}>
{scrollSeekVelocity === 0 ? "Off" : `${scrollSeekVelocity}`}
</span>
</span>
<Tooltip delayDuration={100}>
<TooltipTrigger asChild>
<button className="settingsInfoIcon">
<InfoIcon size={14} weight="fill" aria-label="InfoIcon" />
</button>
</TooltipTrigger>
<TooltipContent>
<p>
Adjust how quickly chat switches to lightweight placeholders while scrolling. Set to 0 to
disable placeholders entirely.
</p>
</TooltipContent>
</Tooltip>
</div>

<Slider
className="settingsSlider"
defaultValue={[scrollSeekVelocity]}
max={2000}
min={0}
step={50}
showTooltip={true}
onValueChange={(value) => {
if (!value.length) return;

const nextValue = Number(value[0]);
if (!Number.isFinite(nextValue)) return;

const clampedValue = Math.max(0, Math.min(Math.round(nextValue), 2000));

onChange("chatrooms", {
...settingsData?.chatrooms,
scrollSeekVelocityThreshold: clampedValue,
});
}}
/>
</div>
</div>
<div className="settingsItem">
<div
className={clsx("settingSwitchItem", {
Expand Down
Loading