-
Notifications
You must be signed in to change notification settings - Fork 1
fix: throttle analytics prompt to monthly #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughAdds a telemetry prompt UI and logic to ChatInput with persistence (localStorage + TTL and legacy migration), updates rendering/memoization to consider telemetry state, and wraps ReplyThread rendering with SettingsProvider while passing settings into ChatInput. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant CI as ChatInput
participant SP as SettingsProvider
participant LS as localStorage
Note over CI: On mount
CI->>LS: Read dismissal record (migrate legacy if needed)
CI->>SP: Read settings.telemetry.enabled
alt telemetry disabled AND no valid dismissal
CI->>CI: showTelemetryPrompt = true
else
CI->>CI: showTelemetryPrompt = false
end
U->>CI: Click "Enable Analytics"
CI->>SP: Update settings.telemetry.enabled = true
CI->>LS: Persist dismissal with TTL
CI->>CI: Hide prompt
U->>CI: Click "Dismiss"
CI->>LS: Persist dismissal with TTL
CI->>CI: Hide prompt
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
🧰 Additional context used📓 Path-based instructions (6)**📄 CodeRabbit inference engine (AGENTS.md)
Files:
src/renderer/src/**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
src/{renderer/src,preload}/**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
src/{main,renderer/src}/**/*.{ts,tsx,js,jsx,mts,mjs,cjs}📄 CodeRabbit inference engine (AGENTS.md)
Files:
src/{main,preload,renderer/src}/**/*.{ts,tsx,js,jsx,mts,mjs,cjs}📄 CodeRabbit inference engine (AGENTS.md)
Files:
!dist/**📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧬 Code graph analysis (3)src/renderer/src/components/Dialogs/ReplyThread.jsx (1)
src/renderer/src/components/Chat/Input/index.jsx (4)
src/renderer/src/dialogs/ReplyThread.jsx (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68dd7eb25ae4833185a25f5bde706947
Summary by CodeRabbit
New Features
Improvements
Performance