Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following deprecation warnings:
QImage::byteCount()
QFileDialog::DirectoryOnly
The fix for 1. requires at least Qt 5.10.
To fix 2., the Qt docs recommend to replace
dialog.setFileMode(QFileDialog::DirectoryOnly)
bydialog.setFileMode(QFileDialog::Directory)
. But this would lead to a dialog just displaying directories. The RdpCacheStitcher docs states this as intended behavior, but the following code assumes a file to be selected and splits the directory part of this file path afterwards. Thus the linedialog.setFileMode(QFileDialog::DirectoryOnly)
was dropped without replacement. If it's intended to just select directories a rewrite of this code logic would be advisable.