Fix aspect ratio limitation for long videos#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements to the development workflow, improves video handling in Telegram sync, and refactors authentication code for clarity and maintainability. The most significant changes include adding a devcontainer for a streamlined development environment, improving how video metadata is extracted and sent to Telegram, and refactoring authentication token handling.
Development Environment Improvements:
.devcontainer/devcontainer.jsonfile to enable development in a standardized containerized environment, including Python and debugging extensions, and a post-create command to install dependencies.Dockerfileto use multi-stage builds for separate production and development images, and updatedcompose.ymlto build using the production target. [1] [2]Video Metadata Extraction and Telegram Sync:
get_video_metadatafunction intools.pyto extract width, height, and duration from MP4 video bytes usingffprobe, and integrated it intotelegram_sync.pyto send videos to Telegram with accurate metadata (width, height, duration). [1] [2] [3]Authentication and Code Quality Improvements:
google_auth_wrapper.pyto import authentication constants and utility functions directly, improving readability and maintainability. Enhanced error handling for homegraph responses and improved logging by using a censor function for access tokens. [1] [2] [3] [4] [5]VSCode Workspace Enhancements:
google-nest-telegram-sync.code-workspaceto add a debug configuration formain.pyand included the newdevuserin spellchecker settings.