Renamed fields for API's variantdata requests #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saramonzon
reviewed
Oct 15, 2024
| @@ -10,7 +10,7 @@ def create_or_get_filter_obj(filter_value): | |||
| if core.models.Filter.objects.filter(filter__iexact=filter_value).exists(): | |||
| return core.models.Filter.objects.filter(filter__iexact=filter_value).last() | |||
| filter_serializer = core.api.serializers.CreateFilterSerializer( | |||
| data={"filter": filter_value} | |||
There was a problem hiding this comment.
I'd prefer this in low case, is it possible?
There was a problem hiding this comment.
Maybe we can apply lowercase to all the fields prior to sending the request
luissian
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the title, this PR includes some field renaming that was leading to errors when trying to update variant data through API requests. This change had to be done because the input file (long_table.json) was reformatted and could not be parsed the same way as before.