Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TA/Tutor Page #112

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Add TA/Tutor Page #112

merged 3 commits into from
Mar 30, 2024

Conversation

L-Gu7
Copy link
Collaborator

@L-Gu7 L-Gu7 commented Mar 29, 2024

This addresses #37

@L-Gu7 L-Gu7 requested a review from aminoa March 29, 2024 04:08
@L-Gu7 L-Gu7 self-assigned this Mar 29, 2024
aminoa
aminoa reviewed Mar 29, 2024
View reviewed changes
Copy link
Member

@aminoa aminoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, I put a brief comment on undergrad TAs (I didn't add it myself cause I wasn't sure if this was a CAS thing or all uni thing besides Tandon). Besides that, good to merge 👍

@L-Gu7
Copy link
Collaborator Author

L-Gu7 commented Mar 29, 2024

Mostly looks good, I put a brief comment on undergrad TAs (I didn't add it myself cause I wasn't sure if this was a CAS thing or all uni thing besides Tandon). Besides that, good to merge 👍

Sorry for the incomplete knowledge. I didn't really know the situation at Tandon, but I think undergrad TAs are quite uncommon at CAS per my experience. I will make an update on this issue.

aminoa
aminoa approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@aminoa aminoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aminoa aminoa merged commit 821f270 into BUGS-NYU:main Mar 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminoa aminoa aminoa approved these changes

Assignees

@L-Gu7 L-Gu7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L-Gu7 @aminoa