Skip to content

Commit

Permalink
its arctan, not tan
Browse files Browse the repository at this point in the history
  • Loading branch information
rocco8773 committed Oct 21, 2024
1 parent 502ecf3 commit 5e44780
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bapsf_motion/transform/lapd_droop.py
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ def _convert_to_droop_points(self, points: np.ndarray) -> np.ndarray:
# - rt => (radius, theta)
points_rt = np.empty_like(_points)
points_rt[..., 0] = np.linalg.norm(_points, axis=1) + self.pivot_to_feedthru
points_rt[..., 1] = np.tan(_points[..., 1] / _points[..., 0])
points_rt[..., 1] = np.arctan(_points[..., 1] / _points[..., 0])

# Calculate dx and dy of the droop
# - delta will always be negative in the ball valve coords
Expand Down

0 comments on commit 5e44780

Please sign in to comment.