Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the limit mode of Motor input configurable #87

Merged
merged 10 commits into from
Jan 22, 2025
Merged

Conversation

rocco8773
Copy link
Member

@rocco8773 rocco8773 commented Jan 21, 2025

This PR does...

  • Adds optional kwarg limit_mode to Motor. Default value is 1 to remain backwards compatible. This kwarg allows the class to be configurable for energized limits (1), de-energized limits (2), or not limits (3).
  • Propagate the limit_mode setting up through the Axis and Drive classes so the setting gets properly passed through to Motor
  • Update MotionGroupConfig to handle both required and optional metadata during every call to _handle_user_meta().
  • Update TOML examples bapsf_motion.toml and benchtop_run.toml to include the limit_mode setting.
  • Add slider widget to the DriveConfigOverlay (actually added to AxisConfigWidget to allow for setting of the limit mode.

closes #86

@rocco8773 rocco8773 added Component | Actor code touching actor functionality Component | GUI code touching the GUI functionality enhancement New feature or request labels Jan 21, 2025
@rocco8773 rocco8773 marked this pull request as ready for review January 22, 2025 01:23
@rocco8773 rocco8773 merged commit e6d88dd into main Jan 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component | Actor code touching actor functionality Component | GUI code touching the GUI functionality enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Make define_limits an input for Motor
1 participant