Skip to content

Conversation

ryantrem
Copy link
Member

@ryantrem ryantrem commented Sep 19, 2025

This PR is mostly about adding the needed exports to extend the inspector with new features. This includes:

  1. Exports from the inspector package itself - these I did selectively from the root index.ts, because what should be part of the public API is only a subset of what is used internally within the inspector itself and future internal tool usage.
  2. Exports from the shared ui package - these I did with an index.ts hierarchy as the intention is that 95% of the Fluent directory should be exported, so I thought this made more sense for this case.
  3. Exports from shared ui package - these are handled the same (selectively export). My previous change commit that added index.ts files for the fluent directory of sharedUiComponents somehow breaks the umd module.d.ts files. I spent a bit of time looking but it wasn't obvious what was going on, so for now I'm directly selectively exporting from the inspector package. We may end up moving these components into the inspector package anyway, so I don't think this is fine.

I also included a small change in this PR where Scene Explorer now hides empty sections (e.g. if there are no post proesses, the "Post Processes" section won't be displayed). This is to minimize the noise/cognitive load when you are only using a subset of the Babylon features.

@ryantrem ryantrem enabled auto-merge (squash) September 19, 2025 00:12
@bjsplat
Copy link
Collaborator

bjsplat commented Sep 19, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 19, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17174/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 19, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17174/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 19, 2025

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/17174/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 19, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 19, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17174/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 19, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17174/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 19, 2025

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/17174/merge/testResults/

@ryantrem ryantrem force-pushed the inspector-v2-exports branch from bfc365f to cf05183 Compare September 22, 2025 20:35
@bjsplat
Copy link
Collaborator

bjsplat commented Sep 22, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 22, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17174/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17174/merge/?snapshot=refs/pull/17174/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 22, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17174/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 22, 2025

@ryantrem ryantrem merged commit 240ee68 into BabylonJS:master Sep 22, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants