Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 31, 2025

Issue reports parent tasks with links incorrectly auto-check when all direct children complete, even if linked page has incomplete tasks. Investigation confirms current logic correctly handles this:

const childrenComplete = t.children.every((c) => c.completed);
const linksComplete = t.linkChildrenComplete ?? true;
const newVal = childrenComplete && linksComplete;  // Both must be true

Parent only checks when BOTH direct children AND linked page tasks are complete.

Changes

  • Added 3 regression tests covering parent task + link + children scenarios
  • Added test fixtures: pageA.md, pageB.md, pageA-complete.md
  • Bumped version to 1.6.6 per instructions

Test Coverage

  1. Parent with incomplete linked page + complete children → remains unchecked ✓
  2. Parent with complete linked page + complete children → becomes checked ✓
  3. Parent with incomplete children (any link state) → remains unchecked ✓
Original prompt

This section details on the original issue you should resolve

<issue_title>Bug: if all the child tasks are completed but their parent linked to page with incomplete tasks</issue_title>
<issue_description>If we have:

...
- [ ] [[pageB]]
 - [x] child A
 - [ ] child B
...

and

...
- [ ] task
...

and child B set checked follows - [x] [[pageB]], but expected to remain unchecked</issue_description>

<agent_instructions>Increment patch version</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits October 31, 2025 11:12
Co-authored-by: BalSla <24732677+BalSla@users.noreply.github.com>
Co-authored-by: BalSla <24732677+BalSla@users.noreply.github.com>
Co-authored-by: BalSla <24732677+BalSla@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix parent task status when child tasks are completed Add regression tests for parent task link behavior and bump to v1.6.6 Oct 31, 2025
Copilot AI requested a review from BalSla October 31, 2025 11:21
@BalSla BalSla marked this pull request as ready for review November 3, 2025 15:05
@BalSla BalSla merged commit 8695038 into master Nov 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: if all the child tasks are completed but their parent linked to page with incomplete tasks

2 participants