Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USDC_Arbi_CowPools-9-13-2024 #1345

Merged
merged 2 commits into from
Sep 13, 2024
Merged

USDC_Arbi_CowPools-9-13-2024 #1345

merged 2 commits into from
Sep 13, 2024

Conversation

Zen-Maxi
Copy link
Collaborator

Copy link
Contributor

FILENAME: MaxiOps/CCTP_Bridge/send/USDC_Arbi_CowPools-9-13-2024.json
COMMIT: 4895015045050694a5385b5b2cdc3c5a431c795d

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip ❌ (No BIP number found in file path MaxiOps/CCTP_Bridge/send/USDC_Arbi_CowPools-9-13-2024.json)
validate_path_has_weekly_dir ❌ (File MaxiOps/CCTP_Bridge/send/USDC_Arbi_CowPools-9-13-2024.json has has no YYYY-W## in path)

Copy link
Contributor

FILENAME: MaxiOps/CCTP_Bridge/send/USDC_Arbi_CowPools-9-13-2024.json
MULTISIG: multisigs/lm (mainnet:0xc38c5f97B34E175FFd35407fc91a937300E33860)
COMMIT: 4895015045050694a5385b5b2cdc3c5a431c795d
CHAIN(S): mainnet
TENDERLY: 🟩 SUCCESS

+----------------+--------------------------------------------------------------------+-------+--------------------------------------------------------------------------+------------+----------+
| fx_name        | to                                                                 | value | inputs                                                                   | bip_number | tx_index |
+----------------+--------------------------------------------------------------------+-------+--------------------------------------------------------------------------+------------+----------+
| approve        | 0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48 (tokens/USDC)           | 0     | {                                                                        | N/A        |   N/A    |
|                |                                                                    |       |   "spender": [                                                           |            |          |
|                |                                                                    |       |     "0xBd3fa81B58Ba92a82136038B25aDec7066af3155 (circle/cctp_messenger)" |            |          |
|                |                                                                    |       |   ],                                                                     |            |          |
|                |                                                                    |       |   "value": [                                                             |            |          |
|                |                                                                    |       |     "raw:15000000000, 18 decimals:1.5E-8, 6 decimals: 15000"             |            |          |
|                |                                                                    |       |   ]                                                                      |            |          |
|                |                                                                    |       | }                                                                        |            |          |
| depositForBurn | 0xBd3fa81B58Ba92a82136038B25aDec7066af3155 (circle/cctp_messenger) | 0     | {                                                                        | N/A        |   N/A    |
|                |                                                                    |       |   "amount": [                                                            |            |          |
|                |                                                                    |       |     "raw:15000000000, 18 decimals:1.5E-8, 6 decimals: 15000"             |            |          |
|                |                                                                    |       |   ],                                                                     |            |          |
|                |                                                                    |       |   "destinationDomain": [                                                 |            |          |
|                |                                                                    |       |     "3"                                                                  |            |          |
|                |                                                                    |       |   ],                                                                     |            |          |
|                |                                                                    |       |   "mintRecipient": [                                                     |            |          |
|                |                                                                    |       |     "0x000000000000000000000000c38c5f97B34E175FFd35407fc91a937300E33860" |            |          |
|                |                                                                    |       |   ],                                                                     |            |          |
|                |                                                                    |       |   "burnToken": [                                                         |            |          |
|                |                                                                    |       |     "0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48 (tokens/USDC)"           |            |          |
|                |                                                                    |       |   ]                                                                      |            |          |
|                |                                                                    |       | }                                                                        |            |          |
+----------------+--------------------------------------------------------------------+-------+--------------------------------------------------------------------------+------------+----------+

@Tritium-VLK
Copy link
Member

Discussed byte order of the recipient in discord. This is well understood. LGTM. 0xc38c5f97B34E175FFd35407fc91a937300E33860

@Tritium-VLK
Copy link
Member

From @Zen-Maxi

report could use a programmed in recipient validation which would be "0x"  + strcpy(dest, &c[40]) or something.. then it checks against address book

@Zen-Maxi Zen-Maxi merged commit 28ceb4c into main Sep 13, 2024
2 checks passed
@Zen-Maxi Zen-Maxi deleted the USDC_Arbi_CowPools-9-13-2024 branch September 13, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants