Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BIP-787] Grant Maxis Amplification Parameter Change Permissions for StableSurge Pools #1784

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[BIP-787] Grant Maxis Amplification Parameter Change Permissions for StableSurge Pools #1784

wants to merge 4 commits into from

Conversation

Zen-Maxi
Copy link
Collaborator

…ableSurge-Pools

Using the action-ids from the deployments repo for each network. For example from Base.

@Zen-Maxi
BIP-XXX-Grant-Maxis-Amplification-Parameter-Change-Permissions-for-St…
601d20b 
…ableSurge-Pools

Using the action-ids from the deployments repo for each network. For example from Base.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025 •
edited
Loading

FILENAME: BIPs/2025-W9/BIP-787-Surge-Amps-Arbitrum.json
COMMIT: b9c76a4b932fb7091765ae661cfbea4d3c6c5434

Validator Result
validate_contains_msig ✅
validate_msig_in_address_book ✅
validate_chain_specified ✅
validate_file_has_bip ✅
validate_path_has_weekly_dir ✅

FILENAME: BIPs/2025-W9/BIP-787-Surge-Amps-Base.json
COMMIT: b9c76a4b932fb7091765ae661cfbea4d3c6c5434

Validator Result
validate_contains_msig ✅
validate_msig_in_address_book ✅
validate_chain_specified ✅
validate_file_has_bip ✅
validate_path_has_weekly_dir ✅

FILENAME: BIPs/2025-W9/BIP-787-Surge-Amps-Gnosis.json
COMMIT: b9c76a4b932fb7091765ae661cfbea4d3c6c5434

Validator Result
validate_contains_msig ✅
validate_msig_in_address_book ✅
validate_chain_specified ✅
validate_file_has_bip ✅
validate_path_has_weekly_dir ✅

FILENAME: BIPs/2025-W9/BIP-787-Surge-Amps-Mainnet.json
COMMIT: b9c76a4b932fb7091765ae661cfbea4d3c6c5434

Validator Result
validate_contains_msig ✅
validate_msig_in_address_book ✅
validate_chain_specified ✅
validate_file_has_bip ✅
validate_path_has_weekly_dir ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025 •
edited
Loading

FILENAME: BIPs/2025-W9/BIP-787-Surge-Amps-Arbitrum.json
MULTISIG: multisigs/dao (arbitrum:0xaF23DC5983230E9eEAf93280e312e57539D098D0)
COMMIT: b9c76a4b932fb7091765ae661cfbea4d3c6c5434
CHAIN(S): arbitrum
TENDERLY: 🟩 SUCCESS

+-----------------------+---------------------+--------------------------------------------+----------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function              | caller_name         | caller_address                             | fx_paths                                                                               | action_ids                                                         |   bip   | tx_index |
+-----------------------+---------------------+--------------------------------------------+----------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRoles | multisigs/maxi_omni | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20250121-v3-stable-surge/StablePool/startAmplificationParameterUpdate(uint256,uint256) | 0x2fbb47746d921903b9f91d439cf9e524a40a377607923d64f01c38c5d0ea1b14 | BIP-787 |    0     |
|                       |                     |                                            | 20250121-v3-stable-surge/StablePool/stopAmplificationParameterUpdate()                 | 0xdecec4789661e9e43897955fb7d3796d8f5159ba0cc6593dbf71f88c8f4da475 |         |          |
+-----------------------+---------------------+--------------------------------------------+----------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

FILENAME: BIPs/2025-W9/BIP-787-Surge-Amps-Base.json
MULTISIG: multisigs/dao (base:0xC40DCFB13651e64C8551007aa57F9260827B6462)
COMMIT: b9c76a4b932fb7091765ae661cfbea4d3c6c5434
CHAIN(S): base
TENDERLY: 🟩 SUCCESS

+-----------------------+---------------------+--------------------------------------------+----------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function              | caller_name         | caller_address                             | fx_paths                                                                               | action_ids                                                         |   bip   | tx_index |
+-----------------------+---------------------+--------------------------------------------+----------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRoles | multisigs/maxi_omni | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20250121-v3-stable-surge/StablePool/startAmplificationParameterUpdate(uint256,uint256) | 0xbf865f1c6f8d104fabfc55638d1622f92901741c27314f329670c51b54f3eded | BIP-787 |    0     |
|                       |                     |                                            | 20250121-v3-stable-surge/StablePool/stopAmplificationParameterUpdate()                 | 0x1a357d5b1643481255960a2981adcdd96069c98aff413a5e8387d5e199d34a64 |         |          |
+-----------------------+---------------------+--------------------------------------------+----------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

FILENAME: BIPs/2025-W9/BIP-787-Surge-Amps-Gnosis.json
MULTISIG: multisigs/dao (gnosis:0x2a5AEcE0bb9EfFD7608213AE1745873385515c18)
COMMIT: b9c76a4b932fb7091765ae661cfbea4d3c6c5434
CHAIN(S): gnosis
TENDERLY: 🟩 SUCCESS

+-----------------------+---------------------+--------------------------------------------+----------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function              | caller_name         | caller_address                             | fx_paths                                                                               | action_ids                                                         |   bip   | tx_index |
+-----------------------+---------------------+--------------------------------------------+----------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRoles | multisigs/maxi_omni | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20250121-v3-stable-surge/StablePool/startAmplificationParameterUpdate(uint256,uint256) | 0x4acf55e494b685b95a5b14cf8c5507d75bd1aa71a85fc1214c0e8b825a469170 | BIP-787 |    0     |
|                       |                     |                                            | 20250121-v3-stable-surge/StablePool/stopAmplificationParameterUpdate()                 | 0x472cb2d86bd228ad5c01dda464760927533d1f2075d5857fb2c01bfee9790125 |         |          |
+-----------------------+---------------------+--------------------------------------------+----------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

FILENAME: BIPs/2025-W9/BIP-787-Surge-Amps-Mainnet.json
MULTISIG: multisigs/dao (mainnet:0x10A19e7eE7d7F8a52822f6817de8ea18204F2e4f)
COMMIT: b9c76a4b932fb7091765ae661cfbea4d3c6c5434
CHAIN(S): mainnet
TENDERLY: 🟩 SUCCESS

+-----------------------+---------------------+--------------------------------------------+----------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function              | caller_name         | caller_address                             | fx_paths                                                                               | action_ids                                                         |   bip   | tx_index |
+-----------------------+---------------------+--------------------------------------------+----------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRoles | multisigs/maxi_omni | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20250121-v3-stable-surge/StablePool/startAmplificationParameterUpdate(uint256,uint256) | 0x3050dfbb6294dc29c5cae13acb241fddea61d345d9b8c809f216c8259b013ff8 | BIP-787 |    0     |
|                       |                     |                                            | 20250121-v3-stable-surge/StablePool/stopAmplificationParameterUpdate()                 | 0x866d7d17a9b007d202e4da84f38a0bfbb310db8184a4f1d2e6de3c8e78ecd1e0 |         |          |
+-----------------------+---------------------+--------------------------------------------+----------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

gosuto-inzasheru
gosuto-inzasheru reviewed Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just needs bip#

couldnt find any other new perms that were introduced by stable surge pools. perms related to the hook were included in bip778 already: #1755

@Xeonus Xeonus changed the title BIP-XXX-Grant-Maxis-Amplification-Parameter-Change-Permissions-for-St… [BIP-787] Grant Maxis Amplification Parameter Change Permissions for StableSurge Pools Feb 18, 2025
@gosuto-inzasheru
Copy link
Collaborator

proposal here: https://forum.balancer.fi/t/bip-787-grant-maxis-amplification-parameter-change-permissions-for-stablesurge-pools/6361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosuto-inzasheru gosuto-inzasheru gosuto-inzasheru approved these changes

@Xeonus Xeonus Awaiting requested review from Xeonus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zen-Maxi @gosuto-inzasheru @Xeonus