Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

41 FOR Formatting #133

Merged
merged 22 commits into from
Sep 11, 2024
Merged

41 FOR Formatting #133

merged 22 commits into from
Sep 11, 2024

Conversation

SSaulenas
Copy link
Collaborator

No description provided.

@SSaulenas SSaulenas linked an issue Aug 30, 2024 that may be closed by this pull request
@SSaulenas SSaulenas changed the title 41 for formatting 41 for formatting do not merge Aug 30, 2024
@SSaulenas
Copy link
Collaborator Author

The issue is that the ForFormatter cannot perform its function correctly because the BlockFormatter first formats the code, altering the index positions. As a result, the ForKeyword is mistakenly treated as an entire code block.

@gustason gustason self-assigned this Sep 9, 2024
@gustason
Copy link
Collaborator

gustason commented Sep 9, 2024

Currently, the formatting is correct, however, 3 tests do not pass because IfFunctionFormatter is not yet compatible with the ForFormatter

@gustason
Copy link
Collaborator

gustason commented Sep 9, 2024

All tests pass now!

@gustason gustason changed the title 41 for formatting do not merge 41 FOR Formatting Sep 11, 2024
@PauliusKu PauliusKu merged commit 95f9e0f into develop Sep 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FOR formatting
3 participants