Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

946 sync basic character object fields #1067

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

georgyrudnev
Copy link
Contributor

@georgyrudnev georgyrudnev commented Dec 31, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • All new classes have class-level documentation comments, if there are any at all
  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation update
  • Other... Please describe:

What is the current behavior?

BasicCharacterObject fields are not sync´d

What is the new behavior?

Resolves #946

Fields should be synced now

Other information

Name, basicHero not sure if need to be synced. MBEquipmentRoster possibly need _equipment collection & field sync.

@georgyrudnev
Copy link
Contributor Author

Name, basicHero not sure if need to be synced. MBEquipmentRoster possibly need _equipment collection & field sync.

@georgyrudnev georgyrudnev requested a review from EgardA January 1, 2025 13:23
Copy link
Contributor

@EgardA EgardA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EgardA EgardA merged commit 164c27b into development Jan 9, 2025
2 checks passed
@EgardA EgardA deleted the 946-Sync-BasicCharacterObjectFields branch January 9, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Sync: BasicCharacterObject Fields
2 participants