-
Notifications
You must be signed in to change notification settings - Fork 5
Cus 3553 m2m memo mode restict #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Robby, just one question and 1 issue caught my eye
* Up to 5 text lines can be defined per error code. | ||
* VALID VALUES: "EDMxxx" where xxx is included in the list of supported error codes. | ||
* | ||
* Supported Error Codes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the only supported error code is 500, could using error code 501 as an example be a bit confusing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Changed the example to use 500.
BNOERRORMODIFIER=BNOERRMODMBRNOTFOUND | ||
ELSE IF VALIDATESTATUS=TARGETACCTCLOSED THEN | ||
DO | ||
BNOERRORMODIFIER=BNOERRMODACCTCLOSED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean for BNOERRORMODIFIER to be immediately overwritten? Also occurs in numerous other areas
@@ -93,6 +93,8 @@ | |||
** Ver. 3.2.6 12/11/2024 T. Kainz - Banno | |||
** * Corrected issue where program was erring when no transfer record FM | |||
** history was found indicating the record creation date | |||
** Ver. 3.3.0 02/04/2025 R. Robison - Banno | |||
** * Adding support for errorDisplayMessage to accomodate memo mode message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rrobison44 , Only thing I see so far is a typo ,accomodate, on line 97 of BANNO.MTMTRANSFERS.V3.POW
CALL PRINTPROGRAMINFO | ||
ERRORCODE=501 | ||
CALL ERRORHANDLER | ||
@RGSTATE=STATEEND |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rrobison44 , I've noticed you've removed all of the lines that say "@rgstate=STATEEND" in BANNO.M2MTRANSFERS.V3.POW. Is that not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rrobison44 , The code looks good!
The only two things I found to take a look at were:
Only thing I see so far is a typo ,accomodate, on line 97 of BANNO.MTMTRANSFERS.V3.POW
And
Hello @rrobison44 , I've noticed you've removed all of the lines that say "@rgstate=STATEEND" in BANNO.M2MTRANSFERS.V3.POW. Is that not needed?
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Robby.
Adds support for EDM CFG param so that a custom message can be returned when a transfer request is attempted while the system is in memo mode.
New code also includes rework of error handling to more closely follow new error handling standards.
Jira CUS-3553