Codegen update #75
Merged
Codegen update #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@santolucito can you confirm that this is what you expected out of the JavaScript and Python codegen? |
santolucito
reviewed
Apr 18, 2024
| -- controller logic | ||
| ++ controller | ||
| ++ "\n\n" | ||
| -- return next cells and outputs (using JS object) |
There was a problem hiding this comment.
isnt this just a dict in python?
There was a problem hiding this comment.
Yea, the input and output to the python function are both dicts.
|
lgtm! this is however a breaking change to a lot of our tools. luckily (I guess?) no one really uses our tools anyway, but it does mean we either need to update moveCube/etc or just take them down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update codegen to produce full function definition for javascript and python