Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacto status publication #421

Merged
merged 15 commits into from
Jan 15, 2024
Merged

Refacto status publication #421

merged 15 commits into from
Jan 15, 2024

Conversation

fufeck
Copy link
Collaborator

@fufeck fufeck commented Nov 29, 2023

PROBLEME

Le system de publication est un peu compliqué a comprendre et est perturbant lorsqu'il y a une mise a jour programmé et pas d'habilitation.

FONCTIONNALITEE

  • Suppression du status READY_TO_PUBLISH, la première publication se fait a partir du status DRAFT
  • Ajout du status WAITING_HABILITATION qui est set lors du cron syncOutdated si le status.sync est OUTDATED mais que l'habilitation n'est plus valide.

@fufeck fufeck marked this pull request as draft November 29, 2023 08:23
@fufeck fufeck force-pushed the fufeck_refacto-status-publication branch from 9a54573 to 6968cff Compare November 29, 2023 12:30
@fufeck fufeck requested a review from MaGOs92 November 29, 2023 14:25
@fufeck fufeck marked this pull request as ready for review December 19, 2023 16:16
Copy link
Collaborator

@MaGOs92 MaGOs92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En faisant une recherche globale, j'ai vu qu'il restait quelques "ready-to-publish" dans le stat service et le search_query.pipe

libs/shared/src/modules/publication/publication.service.ts Outdated Show resolved Hide resolved
@MaGOs92
Copy link
Collaborator

MaGOs92 commented Dec 22, 2023

Tu utilises Nest pour run la migration?

@fufeck fufeck requested a review from MaGOs92 January 8, 2024 08:37
Copy link
Collaborator

@MaGOs92 MaGOs92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fufeck fufeck merged commit dae48d2 into master Jan 15, 2024
2 checks passed
@fufeck fufeck deleted the fufeck_refacto-status-publication branch January 15, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants