Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status conflict in exec publication #427

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

fufeck
Copy link
Collaborator

@fufeck fufeck commented Jan 15, 2024

Context

  • Lorsque le le JOB sync_outdated run, les BALS qui étaient outdated mais dont le lastUploadedRevisionId n'était pas la révision courante publiait normalement alors qu'elle devait normalement finir en Conflict a cause d'une coquille dans la fusion du sync.

  • Remplacement des returnDocument: after par new: true comme préconisé par la doc mongoose

Cela a surement entrainé des problème de conflit

@fufeck fufeck requested a review from MaGOs92 January 15, 2024 15:19
@fufeck fufeck force-pushed the fufeck_fix_status-conflict-in-exec-publication branch from 85f9e39 to 931ec28 Compare January 15, 2024 15:41
@fufeck fufeck changed the title Fufeck fix status conflict in exec publication Fix status conflict in exec publication Jan 17, 2024
Copy link
Collaborator

@MaGOs92 MaGOs92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pour moi, je veux bien que tu re-testes un coup de ton côté

@fufeck fufeck merged commit b90a23d into master Feb 13, 2024
2 checks passed
@fufeck fufeck deleted the fufeck_fix_status-conflict-in-exec-publication branch February 13, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants