-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: route search numero by polygon #474
Merged
Merged
Changes from all commits
Commits
Show all changes
114 commits
Select commit
Hold shift + click to select a range
53e3bcd
start migration
fufeck abe816d
test
fufeck 1753415
add varchar
fufeck 9ce63aa
delete export
fufeck b8a02fc
delete dead package.json
fufeck c2de515
dead code
fufeck 98abed7
link postgres to var env
fufeck 1d2fe68
update voie service
fufeck 152ef3f
update numero service
fufeck 247873a
add findCentroid
fufeck 159557b
stash
fufeck b53561e
change to uuid
fufeck 6e1d790
refacto voie service
fufeck 9a7bf66
avance on numero.service
fufeck ce06436
finish numeros and voie
fufeck 80116d5
fix DTO
fufeck 12a1fdc
migration toponyme service
fufeck 7b8f219
base locales progress
fufeck 87e30f5
finish service baseLocale
fufeck 5d96301
correct import voie
fufeck d07f939
import toponyme
fufeck 5c08215
import many numero
fufeck c178264
progress
fufeck d96b5b0
finish voie service
fufeck 36e00d6
migration export csv
fufeck 8713cf1
migration module habilitation
fufeck e429c97
finish without stat
fufeck 7f3d06c
change geom srid postgis
fufeck be725d3
finish stats modules
fufeck 6b73ced
correct find distinct parcelles
fufeck 6692360
change numeros
fufeck 614a1e1
change entities api property
fufeck 79a3994
object id
fufeck 7f749a9
Merge branch 'master' into fufeck_migration_postgres
fufeck 3840f7d
correct
fufeck 12d08e1
c
fufeck b4c2580
add banId
fufeck 8b854f1
correct server tiles
fufeck e141d0b
correct extend
fufeck 678a5b8
replace uuid to objectId
fufeck 7308e3b
correct insert/update positions
fufeck 65dd3e9
correct import many
fufeck c5afcfd
add import positions
fufeck 8ab7d67
create/update voie
fufeck b91d5f8
create/update toponyme
fufeck e6a7a29
optional function in entities
fufeck 601d305
correct batch numeros toponyme
fufeck c717cd6
correct create update numero
fufeck fc787c8
correct delete numero
fufeck 8f7f072
soft delete toponyme
fufeck 7385247
correct soft delete voie
fufeck 8fa298d
correct route find all bal deleted
fufeck af84e55
correct trash voie
fufeck 23b285d
delete batch
fufeck 503b100
correct batch
fufeck 2525137
correct import many toponyme
fufeck de43699
Merge branch 'master' into fufeck_migration_postgres
fufeck eee6e64
start test
fufeck a7996f9
correct test bases_locales
fufeck d4d0deb
correct test toponyme
fufeck c14c736
correct test voie
fufeck 8382678
correct test numeros
fufeck 1bb96cb
correct test habilitation
fufeck c788b2d
correct test publication
fufeck b387017
add test stats
fufeck 685390a
correct test ci
fufeck 716a870
Merge branch 'master' into fufeck_migration_postgres
fufeck 1246e6c
correct build node 22
fufeck ac5c245
correct await
fufeck e0e6db9
correct connection and migration typeorm
fufeck 4eb4ebd
start cron
fufeck 9773684
add cache to cron
fufeck 234af2f
correct test
fufeck dcf3bae
finish cron
fufeck 3cd22f0
finish test cron
fufeck 1d28947
test cron
fufeck 61669b0
correct build cron
fufeck cf6846c
correct cache string redis
fufeck a120b43
index and rank
fufeck 7d1da03
add migration to module
fufeck 4a355c2
test email to
fufeck 3eb3a8d
correct rank
fufeck cf9c4c1
correct mail
fufeck a99e8f3
correct return bug jules
fufeck d2a8ee1
delete schemas
fufeck cf84b24
add migration in code
fufeck 8404d50
delete bal_id to numero entity
fufeck 873bd4d
correct test
fufeck c55afad
correct lint
fufeck 39e0183
order numeros
fufeck b7f1cf4
correct batch numero -> toponyme null
fufeck f6111ec
correct order csv liste voies
fufeck 64c2808
Merge branch 'master' into fufeck_migration_postgres
fufeck 445f92f
correct bug date updatedAt and sync.currentUpdated
fufeck c4798cd
correct test
fufeck f126acd
correct bases_locales updateOne
fufeck e5ca0c0
correct test
fufeck 3568ee4
refacto migration initialization
fufeck c6e1cb0
update README
fufeck 9ce7a8a
ci: correct coverage soundcloud
fufeck ccea6e6
correct alert souncloud
fufeck 0e35609
correct alert souncloud part 2
fufeck 0701a9a
correct object id mongo length in postgres
fufeck 718ffb8
delete mongoose
fufeck 8e65883
email case insencitive
fufeck 0c8cb5a
change migration
fufeck d86e777
change index
fufeck ee085f3
correct mail balId
fufeck a5b8f7c
add space in numero and suffixe in numeroComplet
fufeck d6fdaf5
feat: route search numeros by polygon
fufeck dfb4e01
Merge branch 'master' into fufeck_feat_route-search-numero-by-polygon
fufeck 07df835
Merge branch 'master' into fufeck_feat_route-search-numero-by-polygon
fufeck ed424e5
Merge branch 'master' into fufeck_feat_route-search-numero-by-polygon
fufeck 6cc3602
Merge branch 'master' into fufeck_feat_route-search-numero-by-polygon
fufeck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import { ApiProperty } from '@nestjs/swagger'; | ||
|
||
export class SearchNumeroDTO { | ||
@ApiProperty({ | ||
type: [Number], | ||
required: true, | ||
nullable: false, | ||
isArray: true, | ||
}) | ||
polygon: number[][]; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Un put pour de la recherche ça me parait pas terrible, on peut pas passer le tableau de coordonnées dans l'URL du GET?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aussi je suis surpris qu'on doive faire un endpoint pour ça. Y'a pas moyen de récupérer les numéros à l'intérieur d'un polygone directement côté front avec maplibre?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alors j'ai utilisé un PUT parce que j'imagine que si la personne fait un polygon complexe (avec beaucoup de coordonées longues) la limit de 2000 caractère dans l'url peut sauter. Après c'est peut être pas utile a toi de me dire
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a pas de route qui retourne les numéros d'une bases_locales et on n peut pas se fier au tuile car il y a seulement les features (numeros) visiblent sur la carte qui sont chargés sur la carte.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm je comprends pas trop. De toute façon l'utilisateur va dessiner le polygone en fonction de ce qui est visible sur la carte.
Tu penses qu'il faut aussi ajouter les numéros supprimés ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Après ok pour le PUT même si ça me parait un peu overkill, je pense pas qu'on est des polygones qui dépassent les 20 points
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il ne va pas forcement dessiner sur un endroit visible au moment du calcule, si il part sur un coté ou dézoom pour rajouter le dernier point. C'est un peut tirer par les cheveux mais ca peut arriver