Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: bug search bal #475

Merged
merged 1 commit into from
Sep 11, 2024
Merged

hotfix: bug search bal #475

merged 1 commit into from
Sep 11, 2024

Conversation

fufeck
Copy link
Collaborator

@fufeck fufeck commented Sep 11, 2024

CONTEXT

Les Bal n'apparaissent pas coté bal-admin

FIX

  • On enlève le andWhere (des emails) dans la requète search si l'email n'est pas defini dans le DTO
  • On remplace = null qui n'est pas interprété par typeorm par IsNull() (pour le deletedAt)

@fufeck fufeck requested a review from MaGOs92 September 11, 2024 08:43
MaGOs92
MaGOs92 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@MaGOs92 MaGOs92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and tests LGTM

@fufeck fufeck merged commit 1ad2fb5 into master Sep 11, 2024
5 checks passed
@fufeck fufeck deleted the fufeck_hotfix_bug-search-bal branch September 11, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaGOs92 MaGOs92 MaGOs92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fufeck @MaGOs92