Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add commune deleguee to voie #487

Closed
wants to merge 7 commits into from
Closed

feat: add commune deleguee to voie #487

wants to merge 7 commits into from

Conversation

fufeck
Copy link
Collaborator

@fufeck fufeck commented Oct 9, 2024

CONTEXT

Pouvoir attribuer des commune déléguées aux voies et toponymes

FEAT

  • Ajouter les champ commune_deleguee au entités voie et toponyme
  • Mettre a jour les DTO create/update des voie et toponyme avec un validator pour les anciennes communes
  • Mettre a jour l'import csv pour que le champ commune_insee_deleguee des fichiers BALs soit digéré
  • Mettre a jour l'export csv pour que le champ commune_insee_deleguee soit bien exporté si il existe en db

@fufeck fufeck mentioned this pull request Oct 9, 2024
Closed
1 task
@MaGOs92 MaGOs92 self-requested a review November 12, 2024 09:03
MaGOs92
MaGOs92 reviewed Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@MaGOs92 MaGOs92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pour moi, il reste les tests à fix

apps/api/test/jest-e2e.json Outdated Show resolved Hide resolved
@fufeck fufeck requested a review from MaGOs92 November 28, 2024 14:10
MaGOs92
MaGOs92 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@MaGOs92 MaGOs92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fufeck fufeck closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaGOs92 MaGOs92 MaGOs92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fufeck @MaGOs92