Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add nomAlt to commune #498

Merged
merged 5 commits into from
Jan 15, 2025
Merged

feat: add nomAlt to commune #498

merged 5 commits into from
Jan 15, 2025

Conversation

fufeck
Copy link
Collaborator

@fufeck fufeck commented Jan 8, 2025 •
edited
Loading

CONTEXT

Pouvoir ajouter des nom régionale pour le nom de commune

FONCTIONNALITE

  • Ajout du champ nomAlt au model bases_locales
  • Ajout du validator pour le nomAltdu DTO de l'update de bases_locales
  • Ajout le parsing des champs commune_nom_@@ pour importer les nom alternatif de commune
  • Ajout des champs commune_nom_@@ a l'export d'un fichier BAL
  • Ajout de la migration postgres

@fufeck fufeck requested review from MaGOs92 and removed request for MaGOs92 January 8, 2025 13:22
MaGOs92
MaGOs92 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@MaGOs92 MaGOs92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

apps/api/src/modules/base_locale/dto/update_base_locale.dto.ts Outdated Show resolved Hide resolved
migrations/1736331743118-commune_add_nom_alt.ts Outdated Show resolved Hide resolved
@fufeck fufeck merged commit 1db9ef4 into master Jan 15, 2025
3 checks passed
@fufeck fufeck deleted the fufeck_feat_add-nom-alt-to-commune branch January 15, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaGOs92 MaGOs92 MaGOs92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fufeck @MaGOs92