Skip to content

Bug fix on discrim<0 case. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bug fix on discrim<0 case. #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cubic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@ const cubicSolve = (a, b, c, d) => {
// Only option left is that all roots are real and unequal (to get here, q < 0)
else {
const dum1 = Math.acos(r / Math.sqrt(-q * -q * -q))
const temp = -term1 + 2.0 * Math.sqrt(-q)
const temp = 2.0 * Math.sqrt(-q)

roots[0].real = temp * Math.cos(dum1 / 3.0)
roots[1].real = temp * Math.cos((dum1 + 2.0 * Math.PI) / 3.0)
roots[2].real = temp * Math.cos((dum1 + 4.0 * Math.PI) / 3.0)
roots[0].real = -term1 + temp * Math.cos(dum1 / 3.0)
roots[1].real = -term1 + temp * Math.cos((dum1 + 2.0 * Math.PI) / 3.0)
roots[2].real = -term1 + temp * Math.cos((dum1 + 4.0 * Math.PI) / 3.0)

return roots
}
Expand Down