Fix Fast Transfer badge overlapping Selected chip#5567
Open
omi-discord-vector[bot] wants to merge 1 commit intomainfrom
Open
Fix Fast Transfer badge overlapping Selected chip#5567omi-discord-vector[bot] wants to merge 1 commit intomainfrom
omi-discord-vector[bot] wants to merge 1 commit intomainfrom
Conversation
Wrap title text in Flexible so it shrinks on narrow screens instead of overflowing into the Selected/Select chip. Add SizedBox(width:10) gap between the Expanded column and the chip for consistent spacing.
Contributor
Greptile SummaryThis PR makes a targeted two-line UI fix in Changes:
Both changes are correct and work together well — Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Outer Row] --> B[Icon Container 44x44]
A --> C[SizedBox width=14]
A --> D[Expanded Column]
A --> E["SizedBox width=10 ✨ NEW"]
A --> F[Selected / Select Chip]
D --> G[Inner Row]
D --> H[SizedBox height=4]
D --> I[Speed Text]
G --> J["Flexible ✨ NEW\n(TextOverflow.ellipsis)"]
G --> K[SizedBox width=8]
G --> L[Badge Container\ne.g. 5X FASTER]
J --> M[Title Text]
Last reviewed commit: cc2aa9a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the Fast Transfer settings page, the "5X FASTER" badge and "Selected" chip overlap on narrower screens because the title text in the inner Row has no flex constraint.
Fix
TextinFlexiblewithTextOverflow.ellipsisso it shrinks instead of overflowingSizedBox(width: 10)gap between the Expanded column and the Selected/Select chipOne-file change in
fast_transfer_settings_page.dart.