Fix: Set PlayerNotificationManager up correctly #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I think there is still some more things to fix before I can do a release for MAUI. Maybe you can try to get the new sample running? |
janwiebe-jump
added a commit
to janwiebe-jump/XamarinMediaManager
that referenced
this pull request
Oct 18, 2022
BajakiGabesz
pushed a commit
to BajakiGabesz/XamarinMediaManager
that referenced
this pull request
Mar 16, 2023
Fix: Set PlayerNotificationManager up correctly
BajakiGabesz
pushed a commit
to BajakiGabesz/XamarinMediaManager
that referenced
this pull request
Mar 16, 2023
Fix: Set PlayerNotificationManager up correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Potential fix for #877 also sets up PlayerNotificationManager in the way Google intends it (Not deprecated)
Notification doesn't spawn correctly.
🆕 What is the new behavior (if this is a feature change)?
Notification should spawn correctly.
💥 Does this PR introduce a breaking change?
Haven't been able to test yet.
🐛 Recommendations for testing
📝 Links to relevant issues/docs
🤔 Checklist before submitting