Fixed setting of locale on iOS

Baseflow · Mar 4, 2024 · b0d3040 · b0d3040
1 parent 518d8bf
commit b0d3040
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 13 deletions.
diff --git a/geocoding_ios/CHANGELOG.md b/geocoding_ios/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 2.4.0
+
+  * Fixes to configure the locale.
+  * Removes the `localeIdentifier` argument from all methods. Use method `setLocaleIdentifier` to configure the locale.
+
 ## 2.3.0
 
   * Implements `isPresent` that always returns true.

diff --git a/geocoding_ios/lib/geocoding_ios.dart b/geocoding_ios/lib/geocoding_ios.dart
@@ -5,24 +5,31 @@ import 'package:geocoding_platform_interface/geocoding_platform_interface.dart';
 
 const MethodChannel _channel = MethodChannel('flutter.baseflow.com/geocoding');
 
-/// An implementation of [GeocodingPlatform] for Android.
+/// An implementation of [GeocodingPlatform] for iOS.
 class GeocodingIOS extends GeocodingPlatform {
   /// Registers this class as the default instance of [GeocodingPlatform].
   static void registerWith() {
     GeocodingPlatform.instance = GeocodingIOS();
   }
 
+  // ignore: public_member_api_docs
+  String? _localeIdentifier;
+
+  @override
+  Future<void> setLocaleIdentifier(
+    String localeIdentifier,
+  ) async {
+    _localeIdentifier = localeIdentifier;
+  }
+
   @override
-  Future<List<Location>> locationFromAddress(
-    String address, {
-    String? localeIdentifier,
-  }) async {
+  Future<List<Location>> locationFromAddress(String address) async {
     final parameters = <String, String>{
       'address': address,
     };
 
-    if (localeIdentifier != null) {
-      parameters['localeIdentifier'] = localeIdentifier;
+    if (_localeIdentifier != null) {
+      parameters['localeIdentifier'] = _localeIdentifier!;
     }
     try {
       final placemarks = await _channel.invokeMethod(
@@ -40,16 +47,15 @@ class GeocodingIOS extends GeocodingPlatform {
   @override
   Future<List<Placemark>> placemarkFromCoordinates(
     double latitude,
-    double longitude, {
-    String? localeIdentifier,
-  }) async {
+    double longitude,
+  ) async {
     final parameters = <String, dynamic>{
       'latitude': latitude,
       'longitude': longitude,
     };
 
-    if (localeIdentifier != null) {
-      parameters['localeIdentifier'] = localeIdentifier;
+    if (_localeIdentifier != null) {
+      parameters['localeIdentifier'] = _localeIdentifier!;
     }
 
     final placemarks =

diff --git a/geocoding_ios/pubspec.yaml b/geocoding_ios/pubspec.yaml
@@ -1,6 +1,6 @@
 name: geocoding_ios
 description: A Flutter Geocoding plugin which provides easy geocoding and reverse-geocoding features.
-version: 2.3.0
+version: 2.4.0
 repository: https://github.com/baseflow/flutter-geocoding/tree/main/geocoding_ios
 issue_tracker: https://github.com/Baseflow/flutter-geocoding/issues