Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 182 and 195 removed deprecation warnings and adds support for Android 34. #197

Conversation

TimHoogstrate
Copy link
Contributor

@TimHoogstrate TimHoogstrate commented Jan 31, 2024

Fixes 182 and 195 adds support for Android 34

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

@TimHoogstrate TimHoogstrate self-assigned this Jan 31, 2024
@TimHoogstrate TimHoogstrate mentioned this pull request Jan 31, 2024
4 tasks
@TimHoogstrate TimHoogstrate changed the title Fixes 182 and removed deprecation warnings. Upgrades compileSDKVersion and adds support for Android 34. Fixes 182 and 195 removed deprecation warnings and adds support for Android 34. Feb 1, 2024
TimHoogstrate and others added 6 commits February 1, 2024 15:14
…/MethodCallHandlerImpl.java

Co-authored-by: Maurits van Beusekom <maurits@baseflow.com>
…/GeocodeListenerAdapter.java

Co-authored-by: Maurits van Beusekom <maurits@baseflow.com>
…/MethodCallHandlerImpl.java

Co-authored-by: Maurits van Beusekom <maurits@baseflow.com>
…/MethodCallHandlerImpl.java

Co-authored-by: Maurits van Beusekom <maurits@baseflow.com>
@TimHoogstrate TimHoogstrate marked this pull request as ready for review February 1, 2024 15:03
Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work

@mvanbeusekom mvanbeusekom merged commit be37c6f into Baseflow:main Feb 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: android 34 sdk support?
2 participants