-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 182 and 195 removed deprecation warnings and adds support for Android 34. #197
Merged
mvanbeusekom
merged 12 commits into
Baseflow:main
from
TimHoogstrate:enhancement/182-remove-deprecation-warnings
Feb 1, 2024
Merged
Fixes 182 and 195 removed deprecation warnings and adds support for Android 34. #197
mvanbeusekom
merged 12 commits into
Baseflow:main
from
TimHoogstrate:enhancement/182-remove-deprecation-warnings
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
10 tasks
mvanbeusekom
requested changes
Feb 1, 2024
geocoding_android/android/src/main/java/com/baseflow/geocoding/GeocodeListenerAdapter.java
Outdated
Show resolved
Hide resolved
geocoding_android/android/src/main/java/com/baseflow/geocoding/Geocoding.java
Outdated
Show resolved
Hide resolved
geocoding_android/android/src/main/java/com/baseflow/geocoding/Geocoding.java
Outdated
Show resolved
Hide resolved
geocoding_android/android/src/main/java/com/baseflow/geocoding/MethodCallHandlerImpl.java
Show resolved
Hide resolved
geocoding_android/android/src/main/java/com/baseflow/geocoding/MethodCallHandlerImpl.java
Show resolved
Hide resolved
geocoding_android/android/src/main/java/com/baseflow/geocoding/MethodCallHandlerImpl.java
Show resolved
Hide resolved
…/MethodCallHandlerImpl.java Co-authored-by: Maurits van Beusekom <maurits@baseflow.com>
…/GeocodeListenerAdapter.java Co-authored-by: Maurits van Beusekom <maurits@baseflow.com>
…/MethodCallHandlerImpl.java Co-authored-by: Maurits van Beusekom <maurits@baseflow.com>
…/MethodCallHandlerImpl.java Co-authored-by: Maurits van Beusekom <maurits@baseflow.com>
mvanbeusekom
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 182 and 195 adds support for Android 34
Pre-launch Checklist
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.md
to add a description of the change.///
).main
.dart format .
and committed any changes.flutter analyze
and fixed any errors.